After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749894 - The PROP_STYLE property from GlEventViewRow should be removed
The PROP_STYLE property from GlEventViewRow should be removed
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-26 11:27 UTC by Jonathan Kang
Modified: 2015-05-28 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Here is the patch (10.60 KB, patch)
2015-05-26 11:28 UTC, Jonathan Kang 		reviewed Details | Review
patch updated (10.97 KB, patch)
2015-05-26 15:03 UTC, Jonathan Kang 		committed Details | Review

Description Jonathan Kang 2015-05-26 11:27:07 UTC 
Since we use a single line for each log entry, so style property for GlEventViewRow is no longer needed.
Comment 1 Jonathan Kang 2015-05-26 11:28:29 UTC 
Created attachment 303998 [details] [review]
Here is the patch
Comment 2 David King 2015-05-26 13:18:09 UTC 
Review of attachment 303998 [details] [review]:

Looks good, just a question about gl_event_view_row_constructed().

::: src/gl-eventviewrow.c
@@ +128,2 @@
 static void
+gl_event_view_row_constructed (GObject *object)

As you removed the only construct-only property, do you still need a constructed vfunc?
Comment 3 Jonathan Kang 2015-05-26 13:29:31 UTC 
I tried to remove gl_event_view_row_constructed (), and met a preblem. I'll figure it out and move the codes in this function to _init ().
Comment 4 Jonathan Kang 2015-05-26 15:03:17 UTC 
Created attachment 304021 [details] [review]
patch updated
Comment 5 David King 2015-05-28 14:04:02 UTC 
Review of attachment 304021 [details] [review]:

Looks good! I pushed this patch to master (with a slight modification to the comment and commit message) as commit a2416e4118ff37249dad731295b58183f4f65f63.