After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749797 - Misc code improvements
Misc code improvements
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal enhancement
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-24 15:33 UTC by Sébastien Wilmet
Modified: 2015-06-24 11:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sébastien Wilmet 2015-05-24 15:33:10 UTC 
As I read the code I do some code improvements (and sometimes bug fixes).

The branch:
https://git.gnome.org/browse/devhelp/log/?h=wip/swilmet/misc-improvements
Comment 1 Frederic Peters 2015-06-14 06:28:54 UTC 
It looks fine, and thank you for that cleaning work; however I spotted someplace the logic got somehow broken:

+    /* Look for an exact link match. If the link is a PAGE,
+     * we can overwrite any previous exact link set. For
+     * example, when looking for GFile, we want the page,
+     * not the struct. */

Looking for "GObject", it gives me as first result a "GObject" link pointing to the "Types and Values / struct GObject" anchor of the GObject page.

Could you look into that?
Comment 2 Sébastien Wilmet 2015-06-14 10:06:20 UTC 
Fixed:
https://git.gnome.org/browse/devhelp/commit/?h=wip/swilmet/misc-improvements

I've bisected the commits, and it was indeed a regression of the commit:
"keyword-model: use GQueues to concatenate lists"

The exact_link was still correctly set, the problem was with sorting the list/queue.

Thanks for the review and for noticing the change!
Comment 3 Frederic Peters 2015-06-24 11:52:07 UTC 
Cool; I merged all of that.