After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749742 - Reuse Clutter.SwipeAction for the workspace switch gesture
Reuse Clutter.SwipeAction for the workspace switch gesture
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: window-management
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-22 17:14 UTC by Carlos Garnacho
Modified: 2015-05-26 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
windowManager: Redo WorkspaceSwitchAction to be a Clutter.SwipeAction (3.15 KB, patch)
2015-05-22 17:14 UTC, Carlos Garnacho
accepted-commit_now Details | Review

Description Carlos Garnacho 2015-05-22 17:14:00 UTC
I'm attaching a patch that just does that, seems to result in simpler code, and we might get touchpad swipes for free when the time arrives :)

NB: this currently depends on bug #749739 to be applied in Clutter, for correct behavior of multi-finger swipes
Comment 1 Carlos Garnacho 2015-05-22 17:14:26 UTC
Created attachment 303835 [details] [review]
windowManager: Redo WorkspaceSwitchAction to be a Clutter.SwipeAction

Just reuse this gesture rather than implementing edge detection ourselves.
As a plus, we might get touchpad swipe support when Clutter handles it.
Comment 2 drago01 2015-05-23 08:19:18 UTC
Review of attachment 303835 [details] [review]:

LG.
Comment 3 Carlos Garnacho 2015-05-26 17:07:44 UTC
Attachment 303835 [details] pushed as 03dbb0f - windowManager: Redo WorkspaceSwitchAction to be a Clutter.SwipeAction