GNOME Bugzilla – Bug 749708
Add coding guidelines style checker
Last modified: 2015-05-22 09:11:27 UTC
Move the style checker from the gnome-chess repo to libgames-support.
Created attachment 303791 [details] [review] Patch for libgames-support Sahil - I added a permissive (MIT) license to your script. Could you apply the patch, then run 'git commit --amend --signoff' to add your name as a signoff? Thi s is to indicate that you approve the license change. (We can use a different license if you want; I picked MIT because it's a simple permissive license, and I don't see any value in using restrictive licenses for supporting scripts like these.) I also ported it to Python 3 by modifying the print statements and switching xra nge to range. I think it might be broken because it's not picking up some obviou s style errors (tabs in diff, missing space before parentheses), but I haven't investigated more yet. At least it's being run properly. I used a symlink so that it will always be kept up to date with whatever version of the style checker is in libgames-support.
Created attachment 303792 [details] [review] Patch for gnome-chess
Created attachment 303793 [details] [review] Patch for libgames-support, attempt #2
Sure Michael, I'll do that.
Signed off and pushed to master, To ssh://ssareen@git.gnome.org/git/libgames-support 8654371..a6c4762 master -> master (In reply to Michael Catanzaro from comment #3) > Created attachment 303793 [details] [review] [review] > Patch for libgames-support, attempt #2
(In reply to Michael Catanzaro from comment #2) > Created attachment 303792 [details] [review] [review] > Patch for gnome-chess Thanks Michael, pushed the change for gnome-chess as well. To ssh://ssareen@git.gnome.org/git/gnome-chess 2700192..77edcf7 master -> master