After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749708 - Add coding guidelines style checker
Add coding guidelines style checker
Status: RESOLVED FIXED
Product: libgnome-games-support
Classification: Other
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: libgames-scores maintainer(s)
libgames-scores maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-22 00:42 UTC by Michael Catanzaro
Modified: 2015-05-22 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for libgames-support (6.72 KB, patch)
2015-05-22 01:27 UTC, Michael Catanzaro
none Details | Review
Patch for gnome-chess (6.61 KB, patch)
2015-05-22 01:28 UTC, Michael Catanzaro
none Details | Review
Patch for libgames-support, attempt #2 (6.60 KB, patch)
2015-05-22 01:33 UTC, Michael Catanzaro
none Details | Review

Description Michael Catanzaro 2015-05-22 00:42:00 UTC
Move the style checker from the gnome-chess repo to libgames-support.
Comment 1 Michael Catanzaro 2015-05-22 01:27:19 UTC
Created attachment 303791 [details] [review]
Patch for libgames-support

Sahil - I added a permissive (MIT) license to your script. Could you apply the patch, then run 'git commit --amend --signoff' to add your name as a signoff? Thi
s is to indicate that you approve the license change. (We can use a different license if you want; I picked MIT because it's a simple permissive license, and I don't see any value in using restrictive licenses for supporting scripts like these.)

I also ported it to Python 3 by modifying the print statements and switching xra
nge to range. I think it might be broken because it's not picking up some obviou
s style errors (tabs in diff, missing space before parentheses), but I haven't investigated more yet. At least it's being run properly. I used a symlink so that it will always be kept up to date with whatever version of the style checker is in libgames-support.
Comment 2 Michael Catanzaro 2015-05-22 01:28:07 UTC
Created attachment 303792 [details] [review]
Patch for gnome-chess
Comment 3 Michael Catanzaro 2015-05-22 01:33:18 UTC
Created attachment 303793 [details] [review]
Patch for libgames-support, attempt #2
Comment 4 Sahil Sareen 2015-05-22 05:51:01 UTC
Sure Michael, I'll do that.
Comment 5 Sahil Sareen 2015-05-22 08:44:46 UTC
Signed off and pushed to master,

To ssh://ssareen@git.gnome.org/git/libgames-support
   8654371..a6c4762  master -> master

(In reply to Michael Catanzaro from comment #3)
> Created attachment 303793 [details] [review] [review]
> Patch for libgames-support, attempt #2
Comment 6 Sahil Sareen 2015-05-22 09:11:27 UTC
(In reply to Michael Catanzaro from comment #2)
> Created attachment 303792 [details] [review] [review]
> Patch for gnome-chess

Thanks Michael, pushed the change for gnome-chess as well.

To ssh://ssareen@git.gnome.org/git/gnome-chess
   2700192..77edcf7  master -> master