After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749698 - Avoid a silent long to int truncation
Avoid a silent long to int truncation
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-21 20:43 UTC by Rui Matos
Modified: 2015-07-17 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid a silent long to int truncation (1.26 KB, patch)
2015-05-21 20:43 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-05-21 20:43:26 UTC 
If the python object contains a value bigger than MAXUINT we'd
silently truncate it when assigning to 'val' and the if condition
would always be true.

This was caught but a coverity scan.
Comment 1 Rui Matos 2015-05-21 20:43:30 UTC 
Created attachment 303784 [details] [review]
Avoid a silent long to int truncation
Comment 2 Simon Feltman 2015-07-17 05:08:12 UTC 
Review of attachment 303784 [details] [review]:

LGTM, thanks.
Comment 3 Rui Matos 2015-07-17 13:20:25 UTC 
Thanks, pushed to all of these:

   5af6c72..8aa3d59  master -> master
      0de8271..ae73849  pygobject-3-14 -> pygobject-3-14
         5cfe5b5..deb3abc  pygobject-3-16 -> pygobject-3-16

Attachment 303784 [details] pushed as deb3abc - Avoid a silent long to int truncation