After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749695 - Add a traditional menubar
Add a traditional menubar
Status: RESOLVED OBSOLETE
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-21 19:53 UTC by Lars Karlitski
Modified: 2017-11-03 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a traditional menubar (31.13 KB, patch)
2015-05-21 19:53 UTC, Lars Karlitski
none Details | Review
Add a traditional menubar (31.13 KB, patch)
2015-06-17 23:32 UTC, Robert Ancell
rejected Details | Review

Description Lars Karlitski 2015-05-21 19:53:29 UTC
Some environments prefer menubars over gear menus. For example, we're carrying
a patch similar to the one attached here in Ubuntu.
Comment 1 Lars Karlitski 2015-05-21 19:53:34 UTC
Created attachment 303781 [details] [review]
Add a traditional menubar

Some desktops prefer a traditional menubar over an app menu.
GtkApplication can detect this and loads menus from different resources
depending on the environment.

Thus, move the exisiting menus into resources instead of manually
loading them from totem's main ui file and add a traditional menubar
(contributed by Tim Lunn <tim@feathertop.org>).

Only show the gear menu when not showing the menubar.
Comment 2 Robert Ancell 2015-06-17 23:32:45 UTC
Created attachment 305507 [details] [review]
Add a traditional menubar

Updated for git master.
Comment 3 Bastien Nocera 2015-07-26 19:54:59 UTC
Review of attachment 305507 [details] [review]:

There's no gear menu in Totem, even if that's how we called it internally.

I, however, don't under why I'd want to merge this code. The patch is unfinished/unpolished, adds support for environments that I'm not interested in supporting, and which I'm unlikely to want to maintain.

::: src/grilo.gresource.xml
@@ +7,3 @@
     <file compressed="true">totem-grilo.conf</file>
   </gresource>
+  <gresource prefix="/org/gnome/Totem">

At the very least, this file should be renamed because it doesn't contain only items related to the overview part of totem (where grilo is used).

::: src/menus-traditional.ui
@@ +6,3 @@
+      <section>
+        <item>
+          <attribute name="label" translatable="yes">Add _Local Video…</attribute>

This is supposed to only work when in the overview/videos list and...

@@ +32,3 @@
+      <section>
+        <item>
+          <attribute name="label" translatable="yes">_Play / Pause</attribute>

... this should only show up when playing a movie.
Comment 4 Daniel van Vugt 2017-11-03 10:13:01 UTC
Please close this bug. Ubuntu's going for the defaults now.