GNOME Bugzilla – Bug 749695
Add a traditional menubar
Last modified: 2017-11-03 10:37:51 UTC
Some environments prefer menubars over gear menus. For example, we're carrying a patch similar to the one attached here in Ubuntu.
Created attachment 303781 [details] [review] Add a traditional menubar Some desktops prefer a traditional menubar over an app menu. GtkApplication can detect this and loads menus from different resources depending on the environment. Thus, move the exisiting menus into resources instead of manually loading them from totem's main ui file and add a traditional menubar (contributed by Tim Lunn <tim@feathertop.org>). Only show the gear menu when not showing the menubar.
Created attachment 305507 [details] [review] Add a traditional menubar Updated for git master.
Review of attachment 305507 [details] [review]: There's no gear menu in Totem, even if that's how we called it internally. I, however, don't under why I'd want to merge this code. The patch is unfinished/unpolished, adds support for environments that I'm not interested in supporting, and which I'm unlikely to want to maintain. ::: src/grilo.gresource.xml @@ +7,3 @@ <file compressed="true">totem-grilo.conf</file> </gresource> + <gresource prefix="/org/gnome/Totem"> At the very least, this file should be renamed because it doesn't contain only items related to the overview part of totem (where grilo is used). ::: src/menus-traditional.ui @@ +6,3 @@ + <section> + <item> + <attribute name="label" translatable="yes">Add _Local Video…</attribute> This is supposed to only work when in the overview/videos list and... @@ +32,3 @@ + <section> + <item> + <attribute name="label" translatable="yes">_Play / Pause</attribute> ... this should only show up when playing a movie.
Please close this bug. Ubuntu's going for the defaults now.