After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749673 - discoverer: Serialize the top level DiscovererInfo
discoverer: Serialize the top level DiscovererInfo
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-21 10:42 UTC by Mathieu Duponchelle
Modified: 2015-06-04 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
discoverer: Serialize the top level DiscovererInfo (3.68 KB, patch)
2015-05-21 10:42 UTC, Mathieu Duponchelle
rejected Details | Review
discoverer: Serialize the top level DiscovererInfo (3.28 KB, patch)
2015-06-04 17:17 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2015-05-21 10:42:16 UTC
Which contains fields such as duration, uri and tags.
Comment 1 Mathieu Duponchelle 2015-05-21 10:42:20 UTC
Created attachment 303738 [details] [review]
discoverer: Serialize the top level DiscovererInfo
Comment 2 Tim-Philipp Müller 2015-05-21 10:54:15 UTC
Comment on attachment 303738 [details] [review]
discoverer: Serialize the top level DiscovererInfo

Looks fine, sorry I missed that last time.

Should we add a flag for serialising the URI as well?
Comment 3 Mathieu Duponchelle 2015-05-21 11:09:56 UTC
(In reply to Tim-Philipp Müller from comment #2)
> Comment on attachment 303738 [details] [review] [review]
> discoverer: Serialize the top level DiscovererInfo
> 
> Looks fine, sorry I missed that last time.
> 

No problem, my mistake :)

> Should we add a flag for serialising the URI as well?

I don't think we want to have such a flag, your call though.
Comment 4 Tim-Philipp Müller 2015-05-21 11:19:23 UTC
My rationale for the extra flag was that people may store the GVariant blob in a database and use the filename or URI as key, in which case you'd store it twice. But it can still be added later of course. Feel free to push.
Comment 5 Tim-Philipp Müller 2015-05-21 11:24:38 UTC
Well, maybe one should make the uri a maybe-string then so we have the option in future.
Comment 6 Mathieu Duponchelle 2015-06-04 17:17:07 UTC
Created attachment 304599 [details] [review]
discoverer: Serialize the top level DiscovererInfo

Which contains fields such as duration, uri and tags.
Comment 7 Mathieu Duponchelle 2015-06-04 17:20:21 UTC
Review of attachment 303738 [details] [review]:

commit decea41ac79de9928b96e74c627c74a3369c6160
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Wed May 20 18:16:07 2015 +0200

    discoverer: Serialize the top level DiscovererInfo
    
    Which contains fields such as duration, uri and tags.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749673

The uri is serialized as a maybe string, an extra flag can be added later if need be
Comment 8 Mathieu Duponchelle 2015-06-04 17:20:55 UTC
Review of attachment 303738 [details] [review]:

This commit was actually the previous one, rejected
Comment 9 Mathieu Duponchelle 2015-06-04 17:21:29 UTC
Review of attachment 304599 [details] [review]:

commit decea41ac79de9928b96e74c627c74a3369c6160
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Wed May 20 18:16:07 2015 +0200

    discoverer: Serialize the top level DiscovererInfo
    
    Which contains fields such as duration, uri and tags.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749673

The uri is serialized as a maybe string, an extra flag can be added later if need be