GNOME Bugzilla – Bug 749670
orientation: Port to iio-sensor-proxy
Last modified: 2015-05-27 09:04:31 UTC
.
Created attachment 303732 [details] [review] orientation: Port to iio-sensor-proxy
Created attachment 303760 [details] [review] orientation: Port to iio-sensor-proxy Instead of talking directly to udev, which can only support a single type of accelerometer, talk to iio-sensor-proxy over D-Bus.
Review of attachment 303760 [details] [review]: ::: plugins/orientation/gsd-orientation-manager.c @@ +357,3 @@ + NULL); + + g_dbus_proxy_call_sync (p->iio_proxy, Should check if we really got a valid ->iio_proxy before this @@ +367,3 @@ + G_CALLBACK (properties_changed), manager); + + properties_changed (manager->priv->iio_proxy, NULL, NULL, manager); If we get the iio proxy before the xrandr proxy won't we miss setting the initial rotation? @@ +442,3 @@ + g_cancellable_cancel (p->cancellable); + g_clear_object (&p->cancellable); + } This was already there but we should really clear ->connection and ->xrandr_proxy here too. In fact we no longer need to keep ->connection around so let's just drop it
Created attachment 303859 [details] [review] orientation: Port to iio-sensor-proxy Instead of talking directly to udev, which can only support a single type of accelerometer, talk to iio-sensor-proxy over D-Bus.
Review of attachment 303859 [details] [review]: Looks fine
Attachment 303859 [details] pushed as b7f6fe3 - orientation: Port to iio-sensor-proxy