After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749650 - Slider tick marks affect vertical positioning
Slider tick marks affect vertical positioning
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 746132
 
 
Reported: 2015-05-20 17:25 UTC by Allan Day
Modified: 2015-12-05 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
widget factory screenshot (112.89 KB, image/png)
2015-05-20 17:25 UTC, Allan Day
Details

Description Allan Day 2015-05-20 17:25:42 UTC
Created attachment 303690 [details]
widget factory screenshot

When there are stop points on a slider, a tick mark is shown below. These make the widget taller, which can in turn affect the positioning of the slider trough. This can be an issue in some cases, as it means that the slider isn't vertically centered. Bug 746132 is one example.

We discussed this on #gnome-design the other day, and it was agreed that the tick marks could be repositioned so that they don't affect the height of the widget.

I'm attaching an image of the favoured solution, when we discussed it.
Comment 1 Lapo Calamandrei 2015-05-21 12:41:17 UTC
uhmph, with the proposed solution we run into problems with fine tune mode :-/
To avoid issues it would be nice to be able to set the position, the height and the color of the marks from the css somehow.
Comment 2 Lapo Calamandrei 2015-05-21 12:42:01 UTC
Conditionally I mean, so it can be changed say for fine tune mode.
Comment 3 Jakub Steiner 2015-05-21 14:48:02 UTC
When you've triggered the fine tune, you probably aren't interested in snapping...
Comment 4 Lapo Calamandrei 2015-05-21 15:14:16 UTC
Not being interested in snapping doesn't make the marks not clash with the bigger trough :-)
Comment 5 Allan Day 2015-05-21 15:19:16 UTC
Makes sense to disable the stops and hide the tick marks when fine tune mode is active.
Comment 6 Lapo Calamandrei 2015-05-21 15:27:54 UTC
Consider that that's a composite widget so we have no transitions, I'd prefer to be able to tweak them, then making them abruptly disappear.
Comment 7 Jakub Steiner 2015-06-23 12:22:13 UTC
I'm guessing this has been closed by accident as the widget isn't vertically centered in gtk+ master...
Comment 8 Matthias Clasen 2015-06-23 13:37:18 UTC
I've pushed another tweak.

With this change, the remaining difference in the drawing is down
to asymmetric assets and margins coming out of the theme. To fully
support such asymmetric rendering, we need implement baseline alignment
for scales.
Comment 9 Lapo Calamandrei 2015-12-05 14:27:23 UTC
I think with latest gtk+ changes we can close this one, feel free to reopen in case I'm wrong.