After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749623 - crashes if XDG_MUSIC_DIR is unset
crashes if XDG_MUSIC_DIR is unset
Status: RESOLVED OBSOLETE
Product: transmageddon
Classification: Applications
Component: General
1.5
Other Linux
: Normal normal
: ---
Assigned To: Christian Fredrik Kalager Schaller
Christian Fredrik Kalager Schaller
Depends on:
Blocks:
 
 
Reported: 2015-05-20 09:59 UTC by Fabian Greffrath
Modified: 2021-05-25 11:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
check for self.audiodirectory being None before calling os.path.isdir() on it (591 bytes, patch)
2015-05-20 09:59 UTC, Fabian Greffrath
none Details | Review

Description Fabian Greffrath 2015-05-20 09:59:54 UTC
Created attachment 303649 [details] [review]
check for self.audiodirectory being None before calling os.path.isdir() on it

Hi there,

if XDG_MUSIC_DIR is unset, GLib.get_user_special_dir(GLib.UserDirectory.DIRECTORY_MUSIC) returns None and the subsequent check for os.path.isdir(self.audiodirectory) crashes. The attached patch checks early if self.audiodirectory is None and falls back to $HOME instead. The is a similar check for self.videodirectory, so I assume this one was simply forgotten.

Cheers,

Fabian
Comment 1 André Klapper 2021-05-25 11:28:53 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/transmageddon/-/issues/

Thank you for your understanding and your help.