GNOME Bugzilla – Bug 749622
The demos.h Distributed in Release Tarballs breaks MSVC builds.
Last modified: 2015-06-19 15:48:05 UTC
Hi, Nowadays, since we only build the page setup demo on *NIX platforms, we need to generate demos.h according to the platform for which GTK+ is built for, as the default demos.h that is distributed in the tarballs (that is generated by the scripts) will include the *NIX-only pagesetup.c, which will break the build on Visual Studio, as it does not use the autotools build. I will enclose a patch shortly to: -Stop the distribution of the demos.h -Distribute instead a demos.h.win32 that can be used by Visual Studio builds. With blessings, thank you!
Fan, patch still coming ?
Hi Matthias, Sorry, I must have forgotten and I thought I did that. I will get to it later today, as I am away at this time. With blessings.
Created attachment 304233 [details] [review] Dist a demos.h.win32 instead of demos.h Hi, This patch generates demos.h.win32 for use for Visual Studio builds (which contains only the demos that are suitable for Windows builds), as the default demos.h that was shipped contains items for *NIX builds, which will break the build of gtk3-demo.exe on Visual Studio builds. Let me know if generating a .bat to generate demos.h on Windows would be preferable, but that would mean that a Windows PERL installation will be required at build time. With blessings, thank you!
ping...? As this will affect the patches I will come up with for bug 681965. With blessings, thank you!
Review of attachment 304233 [details] [review]: I only looked at the Makefile.am changes - they look fine.
Hello Matthias, Thanks for the review, I pushed the patch to master as c207b8d. As this was fixing the Visual Studio build, I decided to have the Visual Studio build file updates needed for this bug in the same patch :). With blessings, thank you!