After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749605 - vaapidecodebin needs removal too in thumbnailer (blacklist was vaapidecode only)
vaapidecodebin needs removal too in thumbnailer (blacklist was vaapidecode only)
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Thumbnailer
unspecified
Other Linux
: Normal major
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-19 22:28 UTC by Alban Browaeys
Modified: 2015-08-28 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
blacklist vaapidecodebin for thumbnails (1.17 KB, patch)
2015-08-18 14:33 UTC, Alban Browaeys 		needs-work Details | Review
thumbnailer: Also blacklist new vaapidecodebin (1.37 KB, patch)
2015-08-28 10:19 UTC, Bastien Nocera 		committed Details | Review

Description Alban Browaeys 2015-05-19 22:28:46 UTC 
To let totem thumbnailer process mpeg2 files I have when gsteamer-vaapi master is installed I have to add in thumb_app_setup_play src/totem-video-thumbnailer.c :

		feature = gst_registry_find_feature (registry,
                                             "vaapidecodebin",
                                             GST_TYPE_ELEMENT_FACTORY);
	        if (!feature)
	                return;
	        gst_registry_remove_feature (registry, feature);

after:

		feature = gst_registry_find_feature (registry,
											 "vaapidecode",
											 GST_TYPE_ELEMENT_FACTORY);
		if (!feature)
				return;
		gst_registry_remove_feature (registry, feature);


As current gstreamer-vaapi mpeg2 decoder also has a segfault when seek flush (the sequence header is set to null then dereferenced in parse_slice/decode_slice) this also avoid a segfault in the before mentionned parse/decode slice of vaapi.
Comment 1 Alban Browaeys 2015-08-18 14:33:10 UTC 
Created attachment 309476 [details] [review]
blacklist vaapidecodebin for thumbnails
Comment 2 Bastien Nocera 2015-08-28 10:19:05 UTC 
Review of attachment 309476 [details] [review]:

The commit message has all the right words, but in the wrong order, and you forgot to conjugate the verb.

::: src/totem-video-thumbnailer.c
@@ +419,3 @@
+					     GST_TYPE_ELEMENT_FACTORY);
+	if (!feature)
+		return;

You broke older version of gst-vaapi here.
Comment 3 Bastien Nocera 2015-08-28 10:19:24 UTC 
Created attachment 310168 [details] [review]
thumbnailer: Also blacklist new vaapidecodebin

Since the new version of gstreamer-vaapi ships vaapidecodebin
and not vaapidecode, the work-around added in commit
bd2b876f13aa97e9c4faa917b1b2e0a51c2da8ac
fails to blacklist vaapi.
Comment 4 Bastien Nocera 2015-08-28 10:20:26 UTC 
Attachment 310168 [details] pushed as cc43a50 - thumbnailer: Also blacklist new vaapidecodebin