GNOME Bugzilla – Bug 749597
Add g_autoptr() autocleanup support
Last modified: 2019-02-22 03:51:52 UTC
This would be useful for Builder which uses g_autoptr() quite a bit.
Created attachment 303620 [details] [review] Add g_autoptr() autocleanup support All of the types defined in ggit-types.h are included and the test programs compile.
This looks great to me!
Review of attachment 303620 [details] [review]: If you tested it, sure go ahead. One minor question below ::: libgit2-glib/ggit.h.in @@ -22,2 +22,3 @@ #define __GGIT_H__ +#include <libgit2-glib/ggit-autocleanup.h> does it work with this as the first header? When I did it in gsv I had to put it last, I guess because the types have to be defined first...
(In reply to Paolo Borelli from comment #3) > Review of attachment 303620 [details] [review] [review]: > > If you tested it, sure go ahead. One minor question below > > ::: libgit2-glib/ggit.h.in > @@ -22,2 +22,3 @@ > #define __GGIT_H__ > > +#include <libgit2-glib/ggit-autocleanup.h> > > does it work with this as the first header? When I did it in gsv I had to > put it last, I guess because the types have to be defined first... I directly included all of the types into ggit-autocleanup.h file instead of having them be included indirectly. I compiled the test/example programs until they completed without errors or warnings.
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.