GNOME Bugzilla – Bug 749588
Enable/disable recursive search
Last modified: 2015-05-27 09:21:59 UTC
I've just started working on implementing the new search ui design[0]. Since I think it will take lot of code, I'm diving it into small parts. This first patch adds a gsetting for setting whether the search should be recursive (it will be the backend for the "Search Subfolders" switch). [0] https://github.com/gnome-design-team/gnome-mockups/blob/master/nautilus/nautilus-next/search-options.png
Created attachment 303609 [details] [review] patch
Created attachment 303610 [details] [review] Enable/disable recursive search on the _simple_ search engine The patch attached before (303609) makes it possible to enable/disable the recursive search under the tracker search engine. This one is a patch which the Ubuntu community applied downstream that I think could be useful here too.
Review of attachment 303609 [details] [review]: ::: libnautilus-private/nautilus-search-engine-tracker.c @@ +256,3 @@ + nautilus_preferences = g_settings_new ("org.gnome.nautilus.preferences"); + recursive = g_settings_get_boolean (nautilus_preferences, "enable-recursive-search"); + g_object_set (tracker->details, "recursive", recursive, NULL); did you try the patch? this is not a gobject, and it's giving a critical message...
Created attachment 303682 [details] [review] Enable/disable recursive search with a gsetting Yes, I did. I was already working on the whole search redesign, so the tracker patch depended on the simple search one. Sorry about that. Here's a patch containing all the changes together. again, sorry about that noob's mistake.
Review of attachment 303682 [details] [review]: Just a nitpick, but looks ok, thanks! ::: libnautilus-private/org.gnome.nautilus.gschema.xml.in @@ +74,3 @@ + <default>true</default> + <_summary>Whether to enable recursive search or not</_summary> + <_description>enables or disables recursive search in nautilus.</_description> Caps first letter
Review of attachment 303682 [details] [review]: Ah forgot, you need to write the commit message and following the guidelines written here: https://wiki.gnome.org/GnomeLove/CodeContributionWorkflow#Commit_guidelines You can take a look at previous commits on nautilus to see nautilus specific style.
Created attachment 303765 [details] [review] Toggle recursive search on/off with a gsetting
I'm a little confused, seems this is actually two patches instead of one? But here appears as one patch only (and splinter is a little crazy with this). Can you check? when applied locally it's actually two patches (and in the review the commit message says PATCH [1/2])
Created attachment 303940 [details] [review] Enable/disable recursive search on tracker's search engine https://bugzilla.gnome.org/show_bug.cgi?id=749588 Signed-off-by: Felipe Borges <felipeborges@gnome.org>
Created attachment 303941 [details] [review] GSetting to enable/disable recursive search One of the features of the new search ui design is that it will have a switch allowing the search to be recursive or not. These changes make it possible to enable/disable the recursive search within a gsetting. Signed-off-by: Felipe Borges <felipeborges@gnome.org>
Ok, this time I split it into two patches and attached it with git-bz. srry about the flood. :)
And now we have the same problem as before...no? The first patch checks for a gsetting that is not present... =) Just squash them and give thanks in the commit message to the person that did the other patch or something if you are splitting the patches because of that.
Created attachment 303942 [details] [review] search-engine-tracker: toggle recursive search on/off with a gsetting One of the features of the new search ui design is that it will have a switch allowing the search to be recursive or not. These changes make it possible to enable/disable the recursive search within a gsetting.
Created attachment 303943 [details] [review] search-directory: add gsetting to toggle recursive search on/off One of the features of the new search ui design is that it will have a switch allowing the search to be recursive or not. These changes make it possible to enable/disable the recursive search within a gsetting. Signed-off-by: Felipe Borges <felipeborges@gnome.org>
Created attachment 303944 [details] [review] search-engine: toggle recursive search on/off with a gsetting One of the features of the new search ui design is that it will have a switch allowing the search to be recursive or not. These changes make it possible to enable/disable the recursive search within a gsetting.
Created attachment 303945 [details] [review] search-engine: toggle recursive search on/off with a gsetting One of the features of the new search ui design is that it will have a switch allowing the search to be recursive or not. These changes make it possible to enable/disable the recursive search within a gsetting.
Created attachment 303947 [details] [review] search-engine: toggle recursive search on/off with a gsetting One of the features of the new search ui design is that it will have a switch allowing the search to be recursive or not. These changes make it possible to enable/disable the recursive search within a gsetting.
meh, this time the bug url is missing. o.O
Review of attachment 303947 [details] [review]: Ok now the code part of the patch and the order looks good =) About the commit message: toggle already means on/off, so -> toggle recursive search with a gsetting Free to push after that.
Created attachment 304044 [details] [review] search-engine: toggle recursive search with a gsetting One of the features of the new search ui design is that it will have a switch allowing the search to be recursive or not. These changes make it possible to enable/disable the recursive search within a gsetting.
I've just noticed that the ssh key attached to my gnome git account has expired. Could you please push it for me? Thank you very much.
Pushed, thanks for the patch! Attachment 304044 [details] pushed as 70adcc4 - search-engine: toggle recursive search with a gsetting