After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749561 - gtk3: add support for randr 1.5 monitor objects.
gtk3: add support for randr 1.5 monitor objects.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-05-18 22:56 UTC by Dave Airlie
Modified: 2015-05-22 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to add support for randr 1.5 protocol (4.88 KB, patch)
2015-05-18 22:57 UTC, Dave Airlie 		committed Details | Review

Description Dave Airlie 2015-05-18 22:56:32 UTC 
Upstream XRandR has a new monitor object, gtk should use it where available instead of the crtc/output objects, to support tiled monitors.
Comment 1 Dave Airlie 2015-05-18 22:57:37 UTC 
Created attachment 303555 [details] [review]
patch to add support for randr 1.5 protocol
Comment 2 Matthias Clasen 2015-05-19 04:14:34 UTC 
Review of attachment 303555 [details] [review]:

OK.
Comment 3 Krzesimir Nowak 2015-05-22 09:57:38 UTC 
Review of attachment 303555 [details] [review]:

Not sure if this patch is entirely correct wrt primary monitor index after sorting the array.

::: gdk/x11/gdkscreen-x11.c
@@ +657,3 @@
+  XRRFreeMonitors (rr_monitors);
+
+  g_array_sort (monitors,

Sorting this array invalidates primary_idx variable, IMO.
Comment 4 Matthias Clasen 2015-05-22 11:04:06 UTC 
Thanks for pointing that out! Fixed now, I hope
Comment 5 Krzesimir Nowak 2015-05-22 11:41:40 UTC 
There is a typo in "for (i - 0; i < x11_screen->n_monitors; i++)". It should be "i = 0" instead of substracting a zero.