After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749560 - Add support for libsystemd
Add support for libsystemd
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-18 21:53 UTC by Michael Biebl
Modified: 2015-06-28 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Add support for libsystemd (2.34 KB, patch)
2015-05-18 21:57 UTC, Michael Biebl 		accepted-commit_now Details | Review

Description Michael Biebl 2015-05-18 21:53:33 UTC 
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779753

In systemd v209, released over a year ago, the various libsystemd-* libraries
(libsystemd-journal.so, libsystemd-login.so, libsystem-daemon.so,
libsystemd-id128.so) were merged into a single libsystemd.so library to reduce
code duplication and avoid cyclic dependencies [1].

The attached patch changes the configure check for systemd to first try libsystemd and fall-back to libsystemd-login.
I've also slighly simplified the configure check by bumping the minimum version to v44, so we don't need the v43 exclusion.

Please review and apply.


[1] http://lists.freedesktop.org/archives/systemd-devel/2014-February/017146.html
Comment 1 Michael Biebl 2015-05-18 21:57:56 UTC 
Created attachment 303553 [details] [review]
[PATCH] Add support for libsystemd
Comment 2 Robert Roth 2015-06-27 21:09:07 UTC 
Review of attachment 303553 [details] [review]:

Thanks for the patch, this looks fine, it would be ok to push it, to have it in 3.18.0, and we have some time to test this until then.
Comment 3 Michael Biebl 2015-06-28 15:38:07 UTC 
Committed as 31d37f521d3efdb338b6ec4f83f3dbef68958aa1

Thanks for the review