After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749507 - gtk-2.0.m4 fails to detect a prefixed pkg-config
gtk-2.0.m4 fails to detect a prefixed pkg-config
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-05-17 17:48 UTC by Kylie McClain
Modified: 2015-05-22 04:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch which changes gtk-2.0.m4 to use PKG_PROG_PKG_CONFIG (602 bytes, patch)
2015-05-17 17:48 UTC, Kylie McClain 		reviewed Details | Review
gtk-2.0.m4-fix-pkg-config-detection.patch (639 bytes, patch)
2015-05-19 20:53 UTC, Kylie McClain 		committed Details | Review

Description Kylie McClain 2015-05-17 17:48:36 UTC 
Created attachment 303488 [details] [review]
Patch which changes gtk-2.0.m4 to use PKG_PROG_PKG_CONFIG

With the current code used in the m4 macro, gtk-2.0.m4 can't find a prefixed
pkg-config. This presents issue when cross compiling, as pkg-config needs to be
prefixed to work with the target being compiled for;
ex. `x86_64-pc-linux-gnu-pkg-config` can't be used to compile for a
`i686-pc-linux-gnu` target, so we need to use `i686-pc-linux-gnu-pkg-config`.

I've included a patch which fixes this to use PKG_PROG_PKG_CONFIG rather than the
custom detection code currently in it. I've tested this on Exherbo Linux.
Comment 1 Matthias Clasen 2015-05-19 04:10:45 UTC 
Review of attachment 303488 [details] [review]:

Shouldn't this have some AC_REQUIRE([PKG_PROG_PKG_CONFIG]) then ?
Comment 2 Kylie McClain 2015-05-19 20:53:49 UTC 
Created attachment 303622 [details] [review]
gtk-2.0.m4-fix-pkg-config-detection.patch

Second revision. Added AC_REQUIRE([PKG_PROG_PKG_CONFIG]).