After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749485 - Don't put unexpanded search string in the window title
Don't put unexpanded search string in the window title
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-17 00:47 UTC by Matthias Clasen
Modified: 2015-05-18 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port GpkLanguage code for parsing /usr/share/xml/iso-codes/iso_639.xml (8.71 KB, patch)
2015-05-18 12:33 UTC, Kalev Lember
committed Details | Review
extras: Show the language name instead of raw :lang= search string (4.06 KB, patch)
2015-05-18 12:33 UTC, Kalev Lember
committed Details | Review
extras: Improve user visible font search strings (2.55 KB, patch)
2015-05-18 12:33 UTC, Kalev Lember
committed Details | Review

Description Matthias Clasen 2015-05-17 00:47:19 UTC
I recently noticed a gnome-software notification about 'Additional fonts required'. When I clicked on it, I got a gnome-software window with the title

Available software for :lang=nqo

I think that should be improved to say something like:

Available fonts for the N'Ko script

There's probably similar improvements that can be made for other kinds of packages where we have specific API to install them.
Comment 1 Kalev Lember 2015-05-18 12:33:20 UTC
Created attachment 303518 [details] [review]
Port GpkLanguage code for parsing /usr/share/xml/iso-codes/iso_639.xml

No other changes besides simple search-and-replace Gpk -> Gs.
Comment 2 Kalev Lember 2015-05-18 12:33:29 UTC
Created attachment 303519 [details] [review]
extras: Show the language name instead of raw :lang= search string

When searching for fontconfig resources, parse the passed in :lang=
search string and show the localised language name in user visible
places, instead of the raw search string.
Comment 3 Kalev Lember 2015-05-18 12:33:34 UTC
Created attachment 303520 [details] [review]
extras: Improve user visible font search strings
Comment 4 Kalev Lember 2015-05-18 12:40:14 UTC
screenshot: https://kalev.fedorapeople.org/gnome-software-nko-language.png
Comment 5 Matthias Clasen 2015-05-18 12:54:32 UTC
Not to get too technical here, but I think we're talking about scripts (as in writing systems) here, not languages.
Comment 6 Matthias Clasen 2015-05-18 12:55:58 UTC
See e.g. here: http://en.wikipedia.org/wiki/N%27Ko_alphabet
Comment 7 Kalev Lember 2015-05-18 13:04:08 UTC
Attachment 303518 [details] pushed as 79b9b38 - Port GpkLanguage code for parsing /usr/share/xml/iso-codes/iso_639.xml
Attachment 303519 [details] pushed as cf8857f - extras: Show the language name instead of raw :lang= search string
Attachment 303520 [details] pushed as 97adb3d - extras: Improve user visible font search strings
Comment 8 Kalev Lember 2015-05-18 13:16:23 UTC
(In reply to Matthias Clasen from comment #5)
> Not to get too technical here, but I think we're talking about scripts (as
> in writing systems) here, not languages.

Fair enough, changed to 'script' in https://git.gnome.org/browse/gnome-software/commit/?id=64301b698ab1867d96fedab05f33a03a2e4635cf

Thanks!