After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749449 - Calls to set_markup aren't escaping the tet
Calls to set_markup aren't escaping the tet
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-15 19:22 UTC by Craig Kelly
Modified: 2015-05-18 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for escaping display text sent to set_markup (2.33 KB, patch)
2015-05-15 19:22 UTC, Craig Kelly
committed Details | Review

Description Craig Kelly 2015-05-15 19:22:11 UTC
Created attachment 303448 [details] [review]
Patch for escaping display text sent to set_markup

When run, gnome-tweak-tool is outputting warnings:

(gnome-tweak-tool:26313): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Error on line 1 char 190: Element 'span' was closed, but the currently open element is 'alt'

AFAICT this is because calls to set_markup aren't escaping text. For instance: "Allow keyboard selection of windows and workspaces in overlay mode. <ctrl>number selects a workspace, and <alt>number selects a window."

I've attached a patch. This was seen in Gnome 3.14 on Debian Testing - the patch appears the same on both the master branch and the 3.14 branch.
Comment 1 Matthias Clasen 2015-05-15 20:14:27 UTC
Review of attachment 303448 [details] [review]:

Looks right to me
Comment 2 Matthias Clasen 2015-05-15 20:14:35 UTC
Review of attachment 303448 [details] [review]:

Looks right to me
Comment 3 Rui Matos 2015-05-18 13:09:51 UTC
Thanks for the patch, pushed

   88692c6..00a2362  gnome-3-14 -> gnome-3-14
      f72b5e1..eb23b37  gnome-3-16 -> gnome-3-16
         1b5e742..76f33af  master -> master