After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749440 - power: Fix a crash when reading invalid backlight values
power: Fix a crash when reading invalid backlight values
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-15 16:12 UTC by Rui Matos
Modified: 2015-05-19 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: Fix a crash when reading invalid backlight values (1.03 KB, patch)
2015-05-15 16:12 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-05-15 16:12:27 UTC 
If atoi() returns a negative value this will be interpreted as an
error but the GError wouldn't be set which would crash us when
printing an error message.

See https://bugzilla.redhat.com/show_bug.cgi?id=1222007
Comment 1 Rui Matos 2015-05-15 16:12:30 UTC 
Created attachment 303434 [details] [review]
power: Fix a crash when reading invalid backlight values
Comment 2 Bastien Nocera 2015-05-18 10:50:41 UTC 
Review of attachment 303434 [details] [review]:

Sure.
Comment 3 Rui Matos 2015-05-19 14:17:06 UTC 
173380f..92c470a  gnome-3-16 -> gnome-3-16
      d80738c..631cd5f  master -> master
      
Attachment 303434 [details] pushed as 631cd5f - power: Fix a crash when reading invalid backlight values