After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749389 - Cursors are not aligned
Cursors are not aligned
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: adwaita-icon-theme maintainer(s)
adwaita-icon-theme maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-14 16:54 UTC by LRN
Modified: 2015-05-15 05:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Major cursor realignment (184.45 KB, patch)
2015-05-14 16:55 UTC, LRN
committed Details | Review

Description LRN 2015-05-14 16:54:50 UTC
Slices don't line up.
Similarly-looking cursors have different offsets (when cursors change at runtime, they might bob).
Straight edges are blurry in 32x32 and 64x64.
Comment 1 LRN 2015-05-14 16:55:01 UTC
Created attachment 303390 [details] [review]
Major cursor realignment

* Align slices to the integer grid
* Ensure that similar cursors are aligned to their slices identically
* Fix some stroke widths to be integral
* Try to align as many edges as possible to the 0+N*3 coordinate lines
* Reduce size of some cursors that were too big
Comment 2 LRN 2015-05-14 16:58:31 UTC
Note that:
1) This patch is somewhat dirty. Lots of things change, observing the diff won't help, you need to load up patched and unpatched versions into Inkscape and do visual comparison
2) I've changed shape of some cursors. That may or may not be acceptable.
3) I've made a few cursors smaller (pencil, zoom in/out).
4) Results are somewhat mixed. My goal was to make it look better at 32x32. It doesn't. Maybe it's because of the shadows - they add blurness to sharp edges. Still, left_ptr and left_ptr_watch line up, so that's something at least.
Comment 3 Jakub Steiner 2015-05-14 19:57:36 UTC
I'm afraid there's two majors problems I have with the realignment. The open hand now has completely skewed proportions. But the biggest problem is with the watch cursors, at the native resolution they are completely blurry, snapping to exactly half of the pixel grid.
Comment 4 Jakub Steiner 2015-05-14 20:29:04 UTC
On a second evaluation the watch cursor really didn't fit at all even when pixel snapped, due to it's wider outer stroke. Attaching the patch with some stylistic modification, hopefully not completely ruining the alignment.
Comment 5 LRN 2015-05-15 05:02:51 UTC
I you mean the "watch" cursor, i didn't touch it at all. I did move "left_ptr_watch" up a bit, and moved its shadow to the right.
Comment 6 Jakub Steiner 2015-05-15 05:08:02 UTC
Comment on attachment 303390 [details] [review]
Major cursor realignment

Attachment 303390 [details] pushed as 9eae7cb - Major cursor realignment
Comment 7 Jakub Steiner 2015-05-15 05:15:15 UTC
The tweaked patch with the rendered cursors were too big for bugzilla. Just landed it in master.