GNOME Bugzilla – Bug 749381
Misc small cleanups for the keyboard panel
Last modified: 2015-05-15 17:44:19 UTC
This patch series removes some unused code, and fixes one bug when non-writable gsettings keys are used (though I did not test the latter as I'm not sure how to make a dconf key as read-only :(
Created attachment 303368 [details] [review] keyboard: Make CcKeyboardItem::binding private It's not used outside of CcKeyboardItem
Created attachment 303369 [details] [review] keyboard: Remove unused cc_keyboard_item_get_binding
Created attachment 303370 [details] [review] keyboard: Remove 'gettext_package' handling It's part of CcKeyboardItem but nothing uses it. It's also parsed when loading KeyListEntry XML, but never used (not to be confused with KeyList::package which is used).
Created attachment 303371 [details] [review] keyboard: Remove unused CcKeyboardItem::group
Created attachment 303372 [details] [review] keyboard: Honor immutable command/name in custom commands If the gsettings key for the command or name of a custom shortcut is not writable, the keyboard panel still lets you edit them. This commits makes the corresponding widgets unsensitive when the gsettings key is not writable.
Review of attachment 303368 [details] [review]: Sure.
Review of attachment 303369 [details] [review]: Looks good.
Review of attachment 303370 [details] [review]: I would mention though that we don't use it because the descriptions are translated according to KeyList::package before we even tried to assign ::gettext_package.
Review of attachment 303371 [details] [review]: Add a mention that the BindingGroupType is stored in the section tree model instead.
Review of attachment 303372 [details] [review]: Looks good.
Attachment 303368 [details] pushed as b7a2d17 - keyboard: Make CcKeyboardItem::binding private Attachment 303369 [details] pushed as 241b403 - keyboard: Remove unused cc_keyboard_item_get_binding Attachment 303370 [details] pushed as b442126 - keyboard: Remove 'gettext_package' handling Attachment 303371 [details] pushed as 4257d87 - keyboard: Remove unused CcKeyboardItem::group Attachment 303372 [details] pushed as 5f7ee29 - keyboard: Honor immutable command/name in custom commands