After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749375 - lr/tap-tests: use TAP formatter from tests
lr/tap-tests: use TAP formatter from tests
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-05-14 12:54 UTC by Lubomir Rintel
Modified: 2015-05-26 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lubomir Rintel 2015-05-14 12:54:41 UTC 
The nice thing about this is that the results can be integrated into CI.

ca1289f tests: use the TAP formatter
6c36bb2 build: switch to parallel test harness
d817a58 tests: call g_test_run() even when skipping the test
2639060 tests: always spawn private d-bus
c74408a tests: move all asserts into tests

Bumps requirement of automake from 1.11 to 1.12.
Comment 1 Thomas Haller 2015-05-14 13:19:53 UTC 
>> tests: move all asserts into tests

pushed a fixup!


>> tests: call g_test_run() even when skipping the test
    
src/rdisc/tests/test-rdisc-fake.c:

it also has a "return EXIT_SKIP;". Replace that too?





`make check` fails for me. Is it because of --with-valgrind=yes ?

make[1]: Leaving directory '/data/src/NetworkManager/introspection'
Making check in libnm-core
make[1]: Entering directory '/data/src/NetworkManager/libnm-core'
make  check-recursive
make[2]: Entering directory '/data/src/NetworkManager/libnm-core'
Making check in .
make[3]: Entering directory '/data/src/NetworkManager/libnm-core'
make[3]: Leaving directory '/data/src/NetworkManager/libnm-core'
Making check in tests
make[3]: Entering directory '/data/src/NetworkManager/libnm-core/tests'
make  check-TESTS
make[4]: Entering directory '/data/src/NetworkManager/libnm-core/tests'
make[5]: Entering directory '/data/src/NetworkManager/libnm-core/tests'
ERROR: test-compare - missing test plan
ERROR: test-crypto - missing test plan
ERROR: test-general - missing test plan
...
Comment 2 Dan Williams 2015-05-15 16:48:12 UTC 
Looks good to me in general.  You missed adding the test driver to src/rdisc/tests/Makefile.am, so I pushed fixups for that.

Now that EXIT_SKIP isn't used anymore, it should probably get removed.  But tools/run-test-valgrind.sh uses the exit code, so it needs to get pulled out of there too.
Comment 3 Lubomir Rintel 2015-05-26 11:56:59 UTC 
defe992 merge: branch 'lr/tap-tests' (bgo #749375)
02e3d6c tests: don't try to connect to the private socket
dd95908 tests: be a bit more helpful when valgrind tests fail
6463ce5 tests: use the TAP formatter
380ed63 build: switch to parallel test harness
14f4674 tests: call g_test_run() even when skipping the test
d0e25ac tests: always spawn private d-bus
f627d6d tests: move all asserts into tests
Comment 4 Thomas Haller 2015-05-26 13:10:43 UTC 
Tests still fail:

make  check-TESTS
make[4]: Entering directory '/data/src/NetworkManager/libnm-core/tests'
make[5]: Entering directory '/data/src/NetworkManager/libnm-core/tests'
ERROR: test-compare - missing test plan
ERROR: test-crypto - missing test plan
ERROR: test-general - missing test plan
ERROR: test-keyfile - missing test plan
Comment 5 Thomas Haller 2015-05-26 14:57:05 UTC 
(In reply to Thomas Haller from comment #4)
> Tests still fail:
> 
> make  check-TESTS
> make[4]: Entering directory '/data/src/NetworkManager/libnm-core/tests'
> make[5]: Entering directory '/data/src/NetworkManager/libnm-core/tests'
> ERROR: test-compare - missing test plan
> ERROR: test-crypto - missing test plan
> ERROR: test-general - missing test plan
> ERROR: test-keyfile - missing test plan

Fixed by http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=ce3d1533cc9aaed14bfa8c03fe66365f2dc1e352