GNOME Bugzilla – Bug 749337
[gnome-shell search provider] excessive logging: "WARNING **: Job failed: Operation was cancelled"
Last modified: 2017-04-17 18:20:40 UTC
Steps to reproduce: 1. enable gnome calendar search provider for gnome shell (in gnome-control-center) 2. in gnome-shell go to overview 3. type something (multiple keys, until at least one calendar entry is found) 4. abort search (e.g. by pressing ESC key) Expected: Nothing should happen except that gnome-shell leaves search / overview Actually happens: Massive logging of this line: ** (gnome-calendar:5847): WARNING **: Job failed: Operation was cancelled
(In reply to Christian Stadelmann from comment #0) > Steps to reproduce: > 1. enable gnome calendar search provider for gnome shell (in > gnome-control-center) > 2. in gnome-shell go to overview > 3. type something (multiple keys, until at least one calendar entry is found) > 4. abort search (e.g. by pressing ESC key) > > Expected: > Nothing should happen except that gnome-shell leaves search / overview > > Actually happens: > Massive logging of this line: > > ** (gnome-calendar:5847): WARNING **: Job failed: Operation was cancelled This log line is usually harmless. We should find the case when we force the cancelling and suppress the log.
The log is generated by gcal-manager.c:181 in thread_job_data_free. How about just adding another condition (that it is G_IO_ERROR_CANCELLED, not G_IOI_ERROR_CANCELLED as the comment in line 180 suggests) to suppress this warning? This is a sample backtrace generating the warning: thread_job_data_free() at gcal-manager.c:181 0x430326 thread_job_thread() at gcal-manager.c:203 0x4307a7 g_thread_proxy() at gthread.c:764 0x7ffff2f440a5 start_thread() at pthread_create.c:333 0x7ffff2627555 clone() at clone.S:109 0x7ffff214af3d
(In reply to Christian Stadelmann from comment #2) > The log is generated by gcal-manager.c:181 in thread_job_data_free. How > about just adding another condition (that it is G_IO_ERROR_CANCELLED, not > G_IOI_ERROR_CANCELLED as the comment in line 180 suggests) to suppress this > warning? > > This is a sample backtrace generating the warning: > thread_job_data_free() at gcal-manager.c:181 0x430326 > thread_job_thread() at gcal-manager.c:203 0x4307a7 > g_thread_proxy() at gthread.c:764 0x7ffff2f440a5 > start_thread() at pthread_create.c:333 0x7ffff2627555 > clone() at clone.S:109 0x7ffff214af3d Yes, as the comment said. I'll fix as soon as I got some time.
Pushed fix as commit e611f87