After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749256 - clutter-backend-gdk: Only set setting on successful gdk_screen_get_setting call
clutter-backend-gdk: Only set setting on successful gdk_screen_get_setting call
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: gdk
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-12 09:27 UTC by Matthieu Bouron
Modified: 2015-05-12 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
clutter-backend-gdk: Only set setting on successful gdk_screen_get_setting call (1.75 KB, patch)
2015-05-12 09:27 UTC, Matthieu Bouron 		committed Details | Review

Description Matthieu Bouron 2015-05-12 09:27:01 UTC 
Created attachment 303251 [details] [review]
clutter-backend-gdk: Only set setting on successful gdk_screen_get_setting call

It could happen that gdk_screen_get_setting fails to retreive Gdk/WindowScalingFactor which leads to the following warnings when clutter_init is called:
    
GLib-GObject-WARNING **: value "0" of type 'gint' is invalid or out of range for property 'window-scaling-factor' of type 'gint'
GLib-GObject-WARNING **: value "0" of type 'gint' is invalid or out of range for property 'dnd-drag-threshold' of type 'gint'

The following patch seems to fix the issue.
Comment 1 Emmanuele Bassi (:ebassi) 2015-05-12 09:53:42 UTC 
Review of attachment 303251 [details] [review]:

Looks good. Please, push to master and to the clutter-1.22 branch.
Comment 2 Matthieu Bouron 2015-05-12 10:10:15 UTC 
(In reply to Emmanuele Bassi (:ebassi) from comment #1)
> Review of attachment 303251 [details] [review] [review]:
> 
> Looks good. Please, push to master and to the clutter-1.22 branch.

I don't have the rights to commit to the clutter repository. Can you push it ?
Comment 3 Gilles Dartiguelongue 2015-05-12 10:12:11 UTC 
Found this running unittests of cheese on Gentoo because we run unittests in Xvfb. Thanks Matthieu for the fix.
Comment 4 Emmanuele Bassi (:ebassi) 2015-05-12 10:16:12 UTC 
Done. Thanks for the patch!

Attachment 303251 [details] pushed as 8aea8bc - clutter-backend-gdk: Only set setting on successful gdk_screen_get_setting call