After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749147 - If there are no projects in the projects view, an invalid back button appears
If there are no projects in the projects view, an invalid back button appears
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal minor
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-09 01:49 UTC by Mitch
Modified: 2015-05-20 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Useless back button on projects (8.08 KB, image/png)
2015-05-09 01:49 UTC, Mitch 		  Details
Back button doesn't show up on dash (1.86 KB, patch)
2015-05-09 17:07 UTC, Mitch 		none Details | Review
Back button fix without debug statements (887 bytes, patch)
2015-05-09 17:10 UTC, Mitch 		accepted-commit_now Details | Review

Description Mitch 2015-05-09 01:49:02 UTC 
Created attachment 303111 [details]
Useless back button on projects

This "back button" doesn't do anything. You click it, and it goes away.
However, since the "Projects" screen is the top-level one (you can't go "back" any further), there is no point to having a back button.
Comment 1 Mitch 2015-05-09 17:07:07 UTC 
To reproduce:
1. Go to the repository-selection screen
2. Click the check-mark on the top bar
3. Hit cancel
4. There is a back button that doesn't do anything
Comment 2 Mitch 2015-05-09 17:07:57 UTC 
Created attachment 303151 [details] [review]
Back button doesn't show up on dash
Comment 3 Mitch 2015-05-09 17:10:16 UTC 
Created attachment 303152 [details] [review]
Back button fix without debug statements

Whoops, last patch had some of my test statements. They're removed!
Comment 4 Ignacio Casal Quinteiro (nacho) 2015-05-15 07:46:08 UTC 
Review of attachment 303152 [details] [review]:

Looks good.
Comment 5 Mitch 2015-05-17 17:35:56 UTC 
What's the next step? Does Jesse put the patch on master, or do I do that somehow?