After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749139 - modernize GObjects in libIDE
modernize GObjects in libIDE
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: libide
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-08 20:57 UTC by Dimitris Zenios
Modified: 2015-12-21 23:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libide: modernize GObjects.Use G_DECLARE_FINAL_TYPE() and G_DECLARE_DERIVABLE_TYPE() (90.36 KB, patch)
2015-05-08 21:35 UTC, Dimitris Zenios 		none Details | Review
libide: modernize GObjects.Use G_DECLARE_FINAL_TYPE() and G_DECLARE_DERIVABLE_TYPE() (84.66 KB, patch)
2015-05-08 22:21 UTC, Dimitris Zenios 		committed Details | Review

Description Dimitris Zenios 2015-05-08 20:57:51 UTC 
Make sure everything that can be changed to G_DECLARE_FINAL_TYPE() or G_DECLARE_DERIVABLE_TYPE() is changed to do so
Comment 1 Christian Hergert 2015-05-08 21:04:33 UTC 
Set to new libide component.
Comment 2 Dimitris Zenios 2015-05-08 21:35:54 UTC 
Created attachment 303107 [details] [review]
libide: modernize GObjects.Use  G_DECLARE_FINAL_TYPE() and G_DECLARE_DERIVABLE_TYPE()

IdeBuffer,IdeSourceView,IdeGitRemoteCallbacks were not converted since we are waiting for GtkSourceView and GgitRemoteCallbacks to be updated to the new g_autoptr functionality
Comment 3 Christian Hergert 2015-05-08 21:55:02 UTC 
Review of attachment 303107 [details] [review]:

LGTM once the gutter renderers are changed back (until GSV 3.17 jump)

::: libide/ide-line-change-gutter-renderer.h
@@ +28,2 @@
+G_DECLARE_FINAL_TYPE (IdeLineChangeGutterRenderer, ide_line_change_gutter_renderer,
+                      IDE, LINE_CHANGE_GUTTER_RENDERER, GtkSourceGutterRenderer)

I don't think we can do this either since GtkSourceView 3.16 doesn't support it yet.

::: libide/ide-line-diagnostics-gutter-renderer.h
@@ +28,1 @@
+G_DECLARE_FINAL_TYPE (IdeLineDiagnosticsGutterRenderer, ide_line_diagnostics_gutter_renderer,

Same here.
Comment 4 Dimitris Zenios 2015-05-08 22:21:53 UTC 
Created attachment 303108 [details] [review]
libide: modernize GObjects.Use  G_DECLARE_FINAL_TYPE() and  G_DECLARE_DERIVABLE_TYPE()

IdeBuffer,IdeSourceView,IdeLineChangeGutterRenderer,IdeLineDiagnosticsGutterRenderer and IdeGitRemoteCallbacks were not converted since we are waiting for GtkSourceView and GgitRemoteCallbacks to be updated to the new g_autoptr functionality
Comment 5 Christian Hergert 2015-05-08 22:24:45 UTC 
LGTM, pushed to master.

Leaving open until the others can be fixed.