After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749127 - The labels in the Properties View lack accessible relations
The labels in the Properties View lack accessible relations
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-08 15:58 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2015-05-09 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add accessible relations between the labels (3.48 KB, patch)
2015-05-08 15:58 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2015-05-08 15:58:30 UTC 
Created attachment 303089 [details] [review]
Add accessible relations between the labels

The properties view grid consists of two columns, the left column contains a GtkLabel which describes, or "labels," the property displayed in the GtkLabel in the right column. The lack of accessible relations between the labels in each column means Orca has no clue that it should also present the label on the left when the user Tabs amongst the labels on the right, and that it should not treat labels on the left as static text.
Comment 1 Carlos Garcia Campos 2015-05-08 17:57:47 UTC 
Comment on attachment 303089 [details] [review]
Add accessible relations between the labels

Ok.
Comment 2 Joanmarie Diggs (IRC: joanie) 2015-05-09 01:37:18 UTC 
Comment on attachment 303089 [details] [review]
Add accessible relations between the labels

Thanks. Committed to master: https://git.gnome.org/browse/evince/commit/?id=7982b946c5

Shall I commit it to the gnome-3-16 branch as well?
Comment 3 Carlos Garcia Campos 2015-05-09 08:50:16 UTC 
(In reply to Joanmarie Diggs (IRC: joanie) from comment #2)
> Comment on attachment 303089 [details] [review] [review]
> Add accessible relations between the labels
> 
> Thanks. Committed to master:
> https://git.gnome.org/browse/evince/commit/?id=7982b946c5
> 
> Shall I commit it to the gnome-3-16 branch as well?

Yes, please.
Comment 4 Joanmarie Diggs (IRC: joanie) 2015-05-09 15:46:48 UTC 
(In reply to Carlos Garcia Campos from comment #3)
> (In reply to Joanmarie Diggs (IRC: joanie) from comment #2)
> > Shall I commit it to the gnome-3-16 branch as well?
> 
> Yes, please.

Done. Thanks! https://git.gnome.org/browse/evince/commit/?id=a6cdc12