After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749104 - video-converter: Change some implicit string enums to real enums
video-converter: Change some implicit string enums to real enums
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-08 12:29 UTC by Vivia Nikolaidou
Modified: 2015-05-08 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch file. (13.75 KB, patch)
2015-05-08 12:29 UTC, Vivia Nikolaidou 		none Details | Review
Patch file, taking comments into account (14.77 KB, patch)
2015-05-08 13:08 UTC, Vivia Nikolaidou 		committed Details | Review

Description Vivia Nikolaidou 2015-05-08 12:29:22 UTC 
Created attachment 303071 [details] [review]
Patch file.

GST_VIDEO_CONVERTER_OPT_ALPHA_MODE, GST_VIDEO_CONVERTER_OPT_CHROMA_MODE,
GST_VIDEO_CONVERTER_OPT_MATRIX_MODE, GST_VIDEO_CONVERTER_OPT_GAMMA_MODE and
GST_VIDEO_CONVERTER_OPT_PRIMARIES_MODE were G_TYPE_STRING with only a few valid
options. Changed those to real enums.
Comment 1 Sebastian Dröge (slomo) 2015-05-08 12:34:53 UTC 
Review of attachment 303071 [details] [review]:

Looks generally good, just some doc cleanup needed

::: gst-libs/gst/video/video-converter.h
@@ +157,3 @@
  * GST_VIDEO_CONVERTER_OPT_ALPHA_MODE:
  *
+ * #G_TYPE_ENUM, the alpha mode to use.

GST_TYPE_VIDEO_ALPHA_MODE

@@ +168,3 @@
  *         #GST_VIDEO_CONVERTER_OPT_ALPHA_VALUE
  *
+ * Default to "copy".

Shouldn't explain all the values as strings but just refer to the docs of the enum
Comment 2 Vivia Nikolaidou 2015-05-08 13:08:38 UTC 
Created attachment 303073 [details] [review]
Patch file, taking comments into account
Comment 3 Sebastian Dröge (slomo) 2015-05-08 13:14:30 UTC 
commit c9cfd0196f2c104091f637e9ebf7a1735bd7c6ab
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Fri May 8 14:57:03 2015 +0300

    video-converter: Change some implicit string enums to real enums
    
    GST_VIDEO_CONVERTER_OPT_ALPHA_MODE, GST_VIDEO_CONVERTER_OPT_CHROMA_MODE,
    GST_VIDEO_CONVERTER_OPT_MATRIX_MODE, GST_VIDEO_CONVERTER_OPT_GAMMA_MODE and
    GST_VIDEO_CONVERTER_OPT_PRIMARIES_MODE were G_TYPE_STRING with only a few valid
    options. Changed those to real enums.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749104