After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749063 - build: General git.mk and MAINTAINERCLEANFILES fixes
build: General git.mk and MAINTAINERCLEANFILES fixes
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-07 10:25 UTC by Philip Withnall
Modified: 2015-05-18 07:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Add git.mk support instead of manual .gitignore files (28.10 KB, patch)
2015-05-07 10:25 UTC, Philip Withnall
committed Details | Review
build: Add generated GResource C and H files to CLEANFILES (4.43 KB, patch)
2015-05-07 10:25 UTC, Philip Withnall
committed Details | Review
build: Remove unnecessary distclean-local rule (810 bytes, patch)
2015-05-07 10:25 UTC, Philip Withnall
committed Details | Review
build: Remove unnecessary MAINTAINERCLEANFILES variables (17.11 KB, patch)
2015-05-07 10:25 UTC, Philip Withnall
committed Details | Review
build: Remove unnecessary DIST_SUBDIRS variable (847 bytes, patch)
2015-05-07 10:25 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2015-05-07 10:25:19 UTC
Patches attached.
Comment 1 Philip Withnall 2015-05-07 10:25:22 UTC
Created attachment 303022 [details] [review]
build: Add git.mk support instead of manual .gitignore files

This makes maintenance of the .gitignore lists a lot easier.
Comment 2 Philip Withnall 2015-05-07 10:25:26 UTC
Created attachment 303023 [details] [review]
build: Add generated GResource C and H files to CLEANFILES

And also don’t distribute them in the source tarball, since they’re
generated files.
Comment 3 Philip Withnall 2015-05-07 10:25:30 UTC
Created attachment 303024 [details] [review]
build: Remove unnecessary distclean-local rule

automake automatically removes the auto4mte.cache directory on
maintainer-clean.
Comment 4 Philip Withnall 2015-05-07 10:25:34 UTC
Created attachment 303025 [details] [review]
build: Remove unnecessary MAINTAINERCLEANFILES variables

The *.in files are automatically cleaned by automake if they are listed
in AC_CONFIG_FILES.

The editor backup files (*~) should not be deleted by the build system.
My editor backup files are my business.
Comment 5 Philip Withnall 2015-05-07 10:25:38 UTC
Created attachment 303026 [details] [review]
build: Remove unnecessary DIST_SUBDIRS variable

By default it is the same as SUBDIRS, so there’s no need to list it
here.
Comment 6 Bastien Nocera 2015-05-17 20:26:32 UTC
Review of attachment 303022 [details] [review]:

Certainly
Comment 7 Bastien Nocera 2015-05-17 20:26:56 UTC
Review of attachment 303023 [details] [review]:

Sure.
Comment 8 Bastien Nocera 2015-05-17 20:27:11 UTC
Review of attachment 303024 [details] [review]:

Yep.
Comment 9 Bastien Nocera 2015-05-17 20:27:34 UTC
Review of attachment 303025 [details] [review]:

Yep.
Comment 10 Bastien Nocera 2015-05-17 20:27:50 UTC
Review of attachment 303026 [details] [review]:

Yup.
Comment 11 Philip Withnall 2015-05-18 07:36:16 UTC
Attachment 303022 [details] pushed as 0878c92 - build: Add git.mk support instead of manual .gitignore files
Attachment 303023 [details] pushed as 9444e0b - build: Add generated GResource C and H files to CLEANFILES
Attachment 303024 [details] pushed as 9ab867a - build: Remove unnecessary distclean-local rule
Attachment 303025 [details] pushed as aeae4f3 - build: Remove unnecessary MAINTAINERCLEANFILES variables
Attachment 303026 [details] pushed as ee1549c - build: Remove unnecessary DIST_SUBDIRS variable