After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749039 - x11: X and XV imagesink don't need to cache the pools
x11: X and XV imagesink don't need to cache the pools
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-06 20:06 UTC by Nicolas Dufresne (ndufresne)
Modified: 2015-06-13 00:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nicolas Dufresne (ndufresne) 2015-05-06 20:06:22 UTC
Since forever, X an XV imagesink has been caching the active pool. The gain of caching the active pool is very small compare to how much negotiation flexibility it removed. When x(v)imagesink propose an already in use pool, the receiver won't be able to change it's configuration unless it is stopped, pipeline drained and started again. It is also harmful in the case an filter moves from passthrough to not passthrough, as offering the active pool will lead to two owners. When the original owner is done with the old pool, it will stop it, which will cause the second owner to eventually receive FLUSING on acquire call.

In this architecture, there is no limitation that would enforce this caching. Hence I suggest we remove it.
Comment 1 Nicolas Dufresne (ndufresne) 2015-06-13 00:30:03 UTC
Fixed, see bug #748344