After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749021 - GtkStackSwitcher: Don't emit notify::visible-child when setting a stack
GtkStackSwitcher: Don't emit notify::visible-child when setting a stack
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-05-06 14:44 UTC by Debarshi Ray
Modified: 2015-05-07 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkStackSwitcher: Don't emit notify::visible-child when setting a stack (1.20 KB, patch)
2015-05-06 14:56 UTC, Debarshi Ray 		committed Details | Review
Sample program (1.30 KB, text/plain)
2015-05-06 14:59 UTC, Debarshi Ray 		  Details

Description Debarshi Ray 2015-05-06 14:44:42 UTC 
Calling gtk_stack_switcher_set_stack can emit notify::visible-child signals atleast twice. These are not harmless because one of these emissions is with a child widget that isn't visible child.
Comment 1 Debarshi Ray 2015-05-06 14:56:01 UTC 
Created attachment 302986 [details] [review]
GtkStackSwitcher: Don't emit notify::visible-child when setting a stack
Comment 2 Debarshi Ray 2015-05-06 14:59:51 UTC 
Created attachment 302987 [details]
Sample program
Comment 3 Matthias Clasen 2015-05-06 19:59:55 UTC 
Review of attachment 302986 [details] [review]:

looks ok to me
Comment 4 Debarshi Ray 2015-05-06 20:34:16 UTC 
Pushed to master.

Is it OK to put it in gtk-3-16? It will avoid having to add a workaround in gnome-documents. It is a behavioural change, but it can be argued that the current behaviour is buggy.
Comment 5 Matthias Clasen 2015-05-07 10:48:14 UTC 
yes, lets put it on 3.16
Comment 6 Debarshi Ray 2015-05-07 13:16:40 UTC 
Pushed to gtk-3-16.