After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749015 - audioscrobbler: Fix displaying icon for libre.fm
audioscrobbler: Fix displaying icon for libre.fm
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: last.fm
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 747559 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-05-06 13:31 UTC by Iain Lane
Modified: 2015-09-06 05:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
audioscrobbler: Fix displaying icon for libre.fm (3.83 KB, patch)
2015-05-06 13:31 UTC, Iain Lane
committed Details | Review

Description Iain Lane 2015-05-06 13:31:50 UTC
We don't ship an icon for libre.fm, so fall back to a default in order
to avoid displaying a not found icon in the sidebar. We attempted to do
this by constructing a GThemedIcon with both the desired name
("Libre.fm-symbolic") and the fallback.

Unfortunately, with this method (once the 'len' parameter to
g_themed_icon_new_for_names () is fixed - another bug), we always get
the fallback icon.

To fix this, we can look the icon up in the Gtk icon theme and only use
it if it is found, falling back otherwise.
Comment 1 Iain Lane 2015-05-06 13:31:53 UTC
Created attachment 302980 [details] [review]
audioscrobbler: Fix displaying icon for libre.fm
Comment 2 Michael Catanzaro 2015-08-31 20:48:34 UTC
*** Bug 747559 has been marked as a duplicate of this bug. ***
Comment 3 Jonathan Matthew 2015-09-06 05:24:57 UTC
pushed as commit 97f9944, thanks
Comment 4 Jonathan Matthew 2015-09-06 05:25:12 UTC
Review of attachment 302980 [details] [review]:

.