GNOME Bugzilla – Bug 748999
y axis mislabelled for cpu use when not dividing by cpu count
Last modified: 2016-05-19 17:26:39 UTC
Created attachment 302961 [details] Screenshot of mislabelled axis. When I look at process view, I prefer to see the CPU usage as a % of individual CPU. So I uncheck the box in the preferences for dividing by cpu count. However, this makes the plot for the cpu resource use go from 0 - $(cpucount * 100). This is wrong, because each line in the CPU plot still only goes from 0-100.
The y axis in the CPU load graph (CPU history) is not normalised properly and it is wrongly made dependent on the "divide CPU usage by CPU count" option in the Preferences. The option "divide CPU usage by CPU count" should only affect the Processes view and not the Resources view.
I have created a patch which fixes both problems and makes the program behave correctly. Please see the attachment...
Created attachment 328155 [details] [review] Patch to properly normalise the y axis in the CPU history graph (Resources tab) The patch applies to the latest 3.20 versions as well as to the git master. It might also apply to earlier versions.
Could you please set Version to "git-master", OS to "All" and eventually choose an higher severity ? Also, the patch needs to be reviewed and eventually committed.
I've made the ticket changes requested.
Thanks Ewan ! Have you tried the patch yet ? I have tested and it resolves the issue. Please note that the "divide CPU usage by CPU count" option refers to the Processes tab...
I have tested this patch and can confirm that the axis labeling now correctly stays at 100% max with or without the dividing by cpu count checkbox marked.
I tested this on top of latest master, commit ad0f1d9e6b7a252f0559bc290f18d2e5b8ce6fad
There is no track of such commit in the git repository at https://git.gnome.org/browse/gnome-system-monitor/
The commit is here: https://git.gnome.org/browse/gnome-system-monitor/patch/?id=ad0f1d9e6b7a252f0559bc290f18d2e5b8ce6fad Bugzilla seems to truncate the gnome part so the link should be: https://git.gnome.org/browse/gnome-system-monitor/commit/?id=ad0f1d9e6b7a252f0559bc290f18d2e5b8ce6fad
That commit is not related to this bug and the patch I submitted.
excuse me for not being clear enought, I just meant I tested the patch on top of ad0f1d9e6b7a252f0559bc290f18d2e5b8ce6fad which is the current master, which then shows the correct results for me. So indeed, this commit has nothing to do with the patch or the current bug, only that it is currently the latest commit in the repository I could find.
Oh right, I understand now what you meant! We need to have that patch committed in the git repository and possibly have a new 3.20 release created. Unfortunately I have no write access, I hope the maintainer will be able to help...
And thanks for testing Jens !
I am quite sure it sorts out the wrong behaviour of the application on Ewan's machine too.
Ewan, can you review the patch ?
If it has not been reviewed first, they might not take it. And since Ewan reported the bug, it's important that he reviews the patch, I suppose.
Attachment 328155 [details] pushed as 14b5e5d - Patch to properly normalise the y axis in the CPU history graph (Resources tab)
(In reply to Guido Trentalancia from comment #17) > If it has not been reviewed first, they might not take it. > > And since Ewan reported the bug, it's important that he reviews the patch, I > suppose. The changeset is fairly straightforward and will have the same effect on all computers, including Ewan's. I have pushed it to master. I am not sure when/if a new 3.20 release will be created, as even if I roll the tarballs, it depends on the distribution you are using (except if you are building from source) whether it gets to you. As this is a minor change, I would say it is perfectly ok to arrive for 3.22. @Guido: Thanks for the proposed patch, and @Jens: thanks for the review, thanks to everyone for making System Monitor better.