After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748985 - GtkSettings: Expose GTK_THEME to external users
GtkSettings: Expose GTK_THEME to external users
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 748987
 
 
Reported: 2015-05-06 02:06 UTC by Garrett Regier
Modified: 2015-07-26 05:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkSettings: Expose GTK_THEME to external users (3.73 KB, patch)
2015-05-06 02:12 UTC, Garrett Regier
none Details | Review
GtkSettings: Expose GTK_THEME to external users v2 (3.78 KB, patch)
2015-05-06 03:16 UTC, Garrett Regier
none Details | Review

Description Garrett Regier 2015-05-06 02:06:25 UTC
Currently the GTK_THEME environment variable is used to load the theme, however it is not actually used to implement the respective GtkSettings properties. This causes external users who load additional CSS, i.e. gedit and gnome-builder, to not load it or load incorrect CSS.
Comment 1 Garrett Regier 2015-05-06 02:12:07 UTC
Created attachment 302949 [details] [review]
GtkSettings: Expose GTK_THEME to external users

Tested with gnome-builder, it now correctly picks up the environment variable.

However, it still doesn't know the correct theme if the originally specified theme is invalid...
Comment 2 Christian Hergert 2015-05-06 03:10:58 UTC
Nice. Small leak when reassigning theme_name.

This would be really nice to have for Builder, when running on systems with interesting theming issues (like Ubuntu).
Comment 3 Garrett Regier 2015-05-06 03:16:27 UTC
Created attachment 302953 [details] [review]
GtkSettings: Expose GTK_THEME to external users v2

(In reply to Christian Hergert from comment #2)
> Nice. Small leak when reassigning theme_name.
> 

Fixed.

> This would be really nice to have for Builder, when running on systems with
> interesting theming issues (like Ubuntu).
Comment 4 Matthias Clasen 2015-05-06 03:26:59 UTC
GTK_THEME is purely a debug tool to override the theme settings, not an alternative way to specify app-specifc settings. I don't want to entangle regular settings with debug tools.
Comment 5 Christian Hergert 2015-05-06 03:57:57 UTC
I guess this would help jhbuild as well?