After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748982 - cursor theme gaps compared to css
cursor theme gaps compared to css
Status: RESOLVED OBSOLETE
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: adwaita-icon-theme maintainer(s)
adwaita-icon-theme maintainer(s)
: 769998 769999 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-05-05 23:08 UTC by Matthias Clasen
Modified: 2020-11-26 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add missing cursor equivalents to the CSS3 spec (210.67 KB, patch)
2015-05-06 17:02 UTC, Jakub Steiner
none Details | Review
add missing cursor equivalents to the CSS3 spec (240.87 KB, patch)
2015-05-06 17:05 UTC, Jakub Steiner
none Details | Review
provide grab cursor, unbreak symlink override of hand1 (1.28 KB, patch)
2015-05-06 18:38 UTC, Jakub Steiner
none Details | Review
all-scroll cursor (18.87 KB, patch)
2015-05-07 07:45 UTC, Jakub Steiner
none Details | Review
add missing cursor equivalents to the CSS3 spec (264.72 KB, patch)
2015-05-07 07:49 UTC, Jakub Steiner
committed Details | Review

Description Matthias Clasen 2015-05-05 23:08:36 UTC
The css3 spec has a reasonable set of defined cursors.
See http://www.w3.org/TR/css3-ui/#cursor
or https://developer.mozilla.org/en-US/docs/Web/CSS/cursor

Here's a list of the gaps we have, compared to that list:

vertical-text (flipped ibeam)
move  (arrow-tipped crosshair)
all-scroll (similar)
zoom-in 
zoom-out
grab (open hand)
Comment 1 Jakub Steiner 2015-05-06 16:26:59 UTC
I think 'hand1' in the existing theme is what 'grab' is supposed to be.
Comment 2 Jakub Steiner 2015-05-06 17:02:39 UTC
Created attachment 302991 [details] [review]
add missing cursor equivalents to the CSS3 spec
Comment 3 Jakub Steiner 2015-05-06 17:05:05 UTC
Created attachment 302992 [details] [review]
add missing cursor equivalents to the CSS3 spec
Comment 4 Jakub Steiner 2015-05-06 18:38:11 UTC
Created attachment 302993 [details] [review]
provide grab cursor, unbreak symlink override of hand1
Comment 5 Jakub Steiner 2015-05-07 07:45:19 UTC
Created attachment 303010 [details] [review]
all-scroll cursor
Comment 6 Jakub Steiner 2015-05-07 07:49:57 UTC
Created attachment 303011 [details] [review]
add missing cursor equivalents to the CSS3 spec

- zoom in, zoom out, move (rename move to pointer-move)
- fix broken symlink override for hand1
- provide grab cursor
- all-scroll
- vertical-text
Comment 7 Jakub Steiner 2015-05-07 07:52:06 UTC
Attachment 303011 [details] pushed as 5ef1bb1 - add missing cursor equivalents to the CSS3 spec
Comment 8 Matthias Clasen 2015-05-08 02:41:40 UTC
I forgot one: context-menu
Comment 9 Matthias Clasen 2015-05-08 02:42:08 UTC
And, btw: I added a cursors demo in gtk3-demo that shows the css cursors.
Comment 10 Mattias Bengtsson 2016-08-16 21:52:22 UTC
(In reply to Jakub Steiner from comment #7)
> Attachment 303011 [details] pushed as 5ef1bb1 - add missing cursor
> equivalents to the CSS3 spec

It seems like the grab cursor became the same as the pointer cursor with this push.

See here: https://www.youtube.com/watch?v=8EnE87OhlSU
Comment 11 Mattias Bengtsson 2016-08-16 23:55:19 UTC
It seems like hand1 and hand2 are the same icon actually:

    /opt/gnome/share/icons/Adwaita/cursors $ sha256sum hand*
    fe607bdeb7f98b37bd0fa992280b709d0988c9323594fd153554e855f6fd3806  hand
    fe607bdeb7f98b37bd0fa992280b709d0988c9323594fd153554e855f6fd3806  hand1
    fe607bdeb7f98b37bd0fa992280b709d0988c9323594fd153554e855f6fd3806  hand2

After digging around a bit more it looks like we're storing the built theme together with its sources inside the same repo and that the theme is simply not in sync with its sources. 

When I run a jhbuild make it doesn't seem to regenerate the theme either.

Look at this:

    ~/Code/gnome/src/adwaita-icon-theme/Adwaita/cursors (master) $ ls -lah hand*
    lrwxrwxrwx 1 mattiasb mattiasb   5 16 aug 22.22 hand -> hand2
    lrwxrwxrwx 1 mattiasb mattiasb   5 16 aug 22.22 hand1 -> hand2
    -rw-rw-r-- 1 mattiasb mattiasb 68K 17 aug 01.36 hand2

hand1 should be its own cursor made from hand1.png

I have no idea how to regenerate the theme though but I hope this was helpful. :)
Comment 12 Mattias Bengtsson 2016-08-17 00:18:25 UTC
If I just wiped the adwaita-icon-theme/Adwaita/cursors/ directory and re-ran make.sh and then did a "jhbuild make" it worked fine and the correct hand1 turned up in the cursor theme.

From a git status afterwards it seems like the watch and the copy cursor also is outdated.
Comment 13 Mattias Bengtsson 2016-08-17 00:21:35 UTC
*** Bug 769998 has been marked as a duplicate of this bug. ***
Comment 14 Mattias Bengtsson 2016-08-17 00:23:30 UTC
*** Bug 769999 has been marked as a duplicate of this bug. ***
Comment 15 André Klapper 2020-11-26 14:41:32 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all older bug reports and feature requests in GNOME Bugzilla which have not seen updates for a while.

If you still use adwaita-icon-theme and if you still see this bug / want this feature in a recent and currently supported version, then please feel free to report it at
https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/
by following the guidelines at
https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines

Thank you for creating this report and we are sorry it could not be implemented so far (volunteer workforce and time is limited).