GNOME Bugzilla – Bug 748914
pnp.ids needs LAP -> BenQ
Last modified: 2016-06-25 12:49:43 UTC
Created attachment 302893 [details] [review] gnome-desktop-benq.patch Downstream at Suse we got a bug that someone's BenQ display was being shown as "Unknown" by the GNOME stack. It turns out that pnp.ids doesn't have an entry for the "LAP" identifier. I'm aware that pnp.ids comes from hwdata, and that it is autogenerated there by downloading a spreadsheet and converting it to CSV and running sed on it and other unspeakable things :) That wasn't exciting enough, so now https://msdn.microsoft.com/en-us/library/windows/hardware/dn610887%28v=vs.85%29.aspx mentions that PNP ids are handled through UEFI, and it points you to http://www.uefi.org/PNP_ACPI_Registry which points you to the canonical list in a PDF http://www.uefi.org/sites/default/files/resources/PNPID_List.pdf which doesn't contain the "LAP BenQ" entry I'm interested in :) So, here is a patch that doesn't shave yaks.
(In reply to Federico Mena Quintero from comment #0) <snip> > So, here is a patch that doesn't shave yaks. Which isn't going to help when we use hwdb to get the pnp IDs.
> Which isn't going to help when we use hwdb to get the pnp IDs. Do you mean systemd/hwdb or hwdata? Should I submit a patch for one of those instead?
(In reply to Federico Mena Quintero from comment #2) > > Which isn't going to help when we use hwdb to get the pnp IDs. > > Do you mean systemd/hwdb or hwdata? Should I submit a patch for one of > those instead? systemd/hwdb, which has a faster version of this code.
Filed upstream as https://bugs.freedesktop.org/show_bug.cgi?id=90524 I don't see how this would be used by gnome-desktop... is it going to use libsystemd?
(In reply to Federico Mena Quintero from comment #4) > Filed upstream as https://bugs.freedesktop.org/show_bug.cgi?id=90524 > > I don't see how this would be used by gnome-desktop... is it going to use > libsystemd? See bug 590059
(In reply to Bastien Nocera from comment #5) > See bug 590059 Nice! Udev, of course, not libsystemd :)
This bug and #590059 (and the one in freedesktop.org) are untouched for a year. Can I just add the BenQ entry directly to pnp.ids now?
Review of attachment 302893 [details] [review]: Sure.
Pushed to gnome-3-20. master uses udev's hwdb to get the pnp.ids so that's where any changes would need to go.