After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748908 - playsink: cannot enable text flag while playing
playsink: cannot enable text flag while playing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-04 17:04 UTC by Arnaud Vrac
Modified: 2015-06-10 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix playsink issue (1.79 KB, patch)
2015-06-10 06:54 UTC, Vineeth
committed Details | Review

Description Arnaud Vrac 2015-05-04 17:04:37 UTC
playbin does not configure the text chain correctly in this scenario:

 - start playing a file with playbin flags=audio|video
 - set flags to audio|video|text

The subtitleoverlay is not linked correctly in this case; playback is stuck in pause when seeking afterwards, and subtitles are never displayed.

To reproduce easily use playback-test, only check Audio and Video playbin checkboxes, press play, and then check the Text playbin checkbox.
Comment 1 Arnaud Vrac 2015-05-04 17:05:14 UTC
Any matroska file with embedded subtitles should allow reproducing the issue.
Comment 2 Vineeth 2015-06-10 06:54:04 UTC
Created attachment 304918 [details] [review]
fix playsink issue

when text playbin is not enabled in the beginning, then
video_srcpad_stream_synchronizer gets linked to videochain->sinkpad
and when we try to enable text bin during play, since it is already linked to videochain, text chain does not get linked properly. Hence unlinking the same
before linking to text chain
Comment 3 Sebastian Dröge (slomo) 2015-06-10 08:39:13 UTC
commit 50beddd474f44767d0f2da3f2036cd51fb7ea490
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Wed Jun 10 15:50:12 2015 +0900

    playsink: cannot enable text flag while playing
    
    when text playbin is not enabled in the beginning, then
    video_srcpad_stream_synchronizer gets linked to videochain->sinkpad
    and when we try to enable text bin during play, since it is already linked to videochain,
    text chain does not get linked properly. Hence unlinking the same
    before linking to text chain
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748908