After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748900 - Don't prepend domain to DHCP-supplied DNS search list
Don't prepend domain to DHCP-supplied DNS search list
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-05-04 15:06 UTC by Beniamino Galvani
Modified: 2015-05-17 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] dns: don't override DHCP-supplied search order with domain (4.06 KB, patch)
2015-05-04 15:09 UTC, Beniamino Galvani
none Details | Review

Description Beniamino Galvani 2015-05-04 15:06:49 UTC
NM always prepends the list of DNS domains received through DHCP to
the search list in /etc/resolv.conf, overriding the DHCP-supplied DNS
domain search order. This behavior is not entirely correct since it
changes the search order provided by system administrators.
Comment 1 Beniamino Galvani 2015-05-04 15:09:08 UTC
Created attachment 302871 [details] [review]
[PATCH] dns: don't override DHCP-supplied search order with domain
Comment 2 Dan Williams 2015-05-05 14:14:33 UTC
LGTM
Comment 3 Thomas Haller 2015-05-06 14:20:10 UTC
LGTM
Comment 4 Beniamino Galvani 2015-05-08 08:47:10 UTC
Merged to master:
6edc7371734315d57de020193102938846b2eb9e

Should this be applied to nm-1-0 too?
Comment 5 Dan Williams 2015-05-15 21:19:58 UTC
(In reply to Beniamino Galvani from comment #4)
> Merged to master:
> 6edc7371734315d57de020193102938846b2eb9e
> 
> Should this be applied to nm-1-0 too?

Yeah, we should do that.
Comment 6 Beniamino Galvani 2015-05-17 17:32:46 UTC
Cherry-picked to branch nm-1-0:
79c80f00ccd0a8ab1e8193ebce4527960b32f139