After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748873 - Documentation and precondition fixes for media resolution
Documentation and precondition fixes for media resolution
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-04 08:19 UTC by Philip Withnall
Modified: 2015-05-08 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
src: Add preconditions to all methods in grl-media.c (19.21 KB, patch)
2015-05-04 08:19 UTC, Philip Withnall 		committed Details | Review
src: Expand documentation for GrlSourceResolveCb (1.16 KB, patch)
2015-05-04 08:19 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2015-05-04 08:19:05 UTC 
Some trivial patches to make it harder to shoot yourself in the foot by not checking whether the GrlMedia is NULL in a GrlSourceResolveCb callback.
Comment 1 Philip Withnall 2015-05-04 08:19:08 UTC 
Created attachment 302838 [details] [review]
src: Add preconditions to all methods in grl-media.c

Otherwise it’s very easy to get a NULL GrlMedia in a GrlSourceResolveCb
callback and start calling methods on it which will happily produce
garbage.
Comment 2 Philip Withnall 2015-05-04 08:19:13 UTC 
Created attachment 302839 [details] [review]
src: Expand documentation for GrlSourceResolveCb
Comment 3 Bastien Nocera 2015-05-07 14:23:34 UTC 
Review of attachment 302838 [details] [review]:

Yes.
Comment 4 Bastien Nocera 2015-05-07 14:28:10 UTC 
Review of attachment 302839 [details] [review]:

Looks good.
Comment 5 Philip Withnall 2015-05-08 10:12:34 UTC 
Attachment 302838 [details] pushed as e9fc0cf - src: Add preconditions to all methods in grl-media.c
Attachment 302839 [details] pushed as 7d981c4 - src: Expand documentation for GrlSourceResolveCb