After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748869 - infinite loop then segv on the second search
infinite loop then segv on the second search
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
1.4.x
Other Linux
: Normal normal
: 1.4
Assigned To: GNOME Commander maintainer(s)
GNOME Commander maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-04 06:40 UTC by Mamoru TASAKA
Modified: 2015-05-09 21:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdb backtrace (37.13 KB, text/x-log)
2015-05-04 06:40 UTC, Mamoru TASAKA 		  Details
Proposal patch (1.74 KB, patch)
2015-05-07 06:16 UTC, Mamoru TASAKA 		none Details | Review

Description Mamoru TASAKA 2015-05-04 06:40:46 UTC 
Created attachment 302834 [details]
gdb backtrace

Both with gnome-commander 1.4.5 and git head, When I
* launch gnome-commander
* Go to some non-empty directory
* Choose "File"->"Search"
* On "Search" dialog, in the text box right of
  "Path matches regex", type some string (for
  search), e.g. "mp4"
* Type enter key, then search result is shown
  (like "Found 36 matches").
* Then select the above text box (with mouse
  left click) and type enter key again.

Then gcmd crashes with segv.
gdb backtrace seems to show that infinite loop happened and gcmd crashed with stack overflow. Currently I have no idea how to fix this.
Comment 1 Uwe Scholz 2015-05-06 18:59:57 UTC 
Hi

thank you very much for your bug report. This issue definitely needs some attention. I also run into this bug some time ago.

Currently, I don't know where to start as the backtrace is not helpful in my case, too. But I will have a deeper look here after fixing bug #653573.
Comment 2 Mamoru TASAKA 2015-05-07 06:16:33 UTC 
Created attachment 303006 [details] [review]
Proposal patch

Looks like the attached proposal patch fixes this issue.
Comment 3 Uwe Scholz 2015-05-08 21:09:51 UTC 
Great! Thank you very much for the bugfix and its detailed explanation, Mamoru! The bug seems to be fixed with this single, but very effective line of code!

I'll apply the patch as soon as possible and it will go into the next bugfix release of gnome commander!

Best wishes,
Uwe
Comment 4 Uwe Scholz 2015-05-09 21:15:47 UTC 
*** Bug 745454 has been marked as a duplicate of this bug. ***