After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748834 - glocalfilemonitor: Emit notification on rate limit change
glocalfilemonitor: Emit notification on rate limit change
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-05-03 11:18 UTC by Philip Withnall
Modified: 2015-05-04 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glocalfilemonitor: Emit notification on rate limit change (1013 bytes, patch)
2015-05-03 11:18 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2015-05-03 11:18:36 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2015-05-03 11:18:40 UTC 
Created attachment 302798 [details] [review]
glocalfilemonitor: Emit notification on rate limit change

The changed variable was previously uninitialised in the path where the
rate limit was actually changed. This could result in the
GObject::notify signal not getting emitted.

Spotted by Coverity.

CID: #1296516
Comment 2 Matthias Clasen 2015-05-04 12:21:57 UTC 
Review of attachment 302798 [details] [review]:

Of course
Comment 3 Philip Withnall 2015-05-04 12:57:08 UTC 
Thanks for the rapid review.

Attachment 302798 [details] pushed as 23a5352 - glocalfilemonitor: Emit notification on rate limit change