After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748828 - g_desktop_app_info_launch_uris_as_manager generates incorrect code.
g_desktop_app_info_launch_uris_as_manager generates incorrect code.
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GLib
0.28.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-03 09:56 UTC by ria.freelander
Modified: 2015-07-03 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for VAPI (998 bytes, patch)
2015-05-03 09:56 UTC, ria.freelander 		none Details | Review

Description ria.freelander 2015-05-03 09:56:56 UTC 
Created attachment 302794 [details] [review]
Patch for VAPI

Example Vala code:
var launch = info.launch_uris_as_manager(null,                                                            Gdk.Display.get_default().get_app_launch_context(),
           SpawnFlags.SEARCH_PATH | SpawnFlags.DO_NOT_REAP_CHILD,                                                  spawn_func,this,launch_callback,this);

It shows this:
			_tmp17_ = g_desktop_app_info_launch_uris_as_manager (_tmp13_, NULL, (GAppLaunchContext*) _tmp16_, G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD, _vala_panel_runner_spawn_func_gspawn_child_setup_func, NULL, self, _vala_panel_runner_launch_callback_gdesktop_app_launch_callback, NULL, self, &_inner_error_);

But must be this:
			_tmp17_ = g_desktop_app_info_launch_uris_as_manager (_tmp13_, NULL, (GAppLaunchContext*) _tmp16_, G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD, _vala_panel_runner_spawn_func_gspawn_child_setup_func, self, _vala_panel_runner_launch_callback_gdesktop_app_launch_callback, self, &_inner_error_);

I included a patch, but this is a GIR-based VAPI, maybe fix will be more generic.
Comment 1 Rico Tzschichholz 2015-07-03 14:48:35 UTC 
commit d5ab9f41984769d90b90811f3851f106f83bd8fe
Author: Rico Tzschichholz <ricotz@ubuntu.com>
Date:   Fri Jul 3 16:46:05 2015 +0200

    gio-unix-2.0: Fix binding of g_desktop_app_info_launch_uris_as_manager
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748828