After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748803 - --enable-debug flag to autogen doesnt add gdb debug symbols in gedit-code-assistance
--enable-debug flag to autogen doesnt add gdb debug symbols in gedit-code-ass...
Status: RESOLVED FIXED
Product: gnome-code-assistance
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Code Assistance maintainers
GNOME Code Assistance maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-02 15:59 UTC by AbdealiJK
Modified: 2015-05-04 07:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add vala flag for gdb symbols (721 bytes, patch)
2015-05-02 16:31 UTC, AbdealiJK
rejected Details | Review
Change vala flag for gdb symbols to -g (722 bytes, patch)
2015-05-03 02:37 UTC, AbdealiJK
committed Details | Review

Description AbdealiJK 2015-05-02 15:59:18 UTC
Not sure about gnome-code-assistance, but in gedit-code-assistance, currently the vala flags doesn't include the -g flag which enables debugging of .vala files using gdb (or nemiver), although all other c files compiled have the gdb symbols.

Adding -g to the vala compiler flags would solve this, or if you think it should not be there, atleast it should be compiled with debug symbols when the --enable-debug flag is passed to autogen (which currently only adds the "--debug" flag to vala compiler
Comment 1 AbdealiJK 2015-05-02 16:31:28 UTC
Created attachment 302761 [details] [review]
Add vala flag for gdb symbols
Comment 2 jessevdk@gmail.com 2015-05-02 16:38:00 UTC
I don't understand how this changes things, according to the valac manpage (http://linux.die.net/man/1/valac), --debug is just the long option form of -g, i.e. the two should be equivalent. Am I missing something?
Comment 3 AbdealiJK 2015-05-02 16:44:42 UTC
Oh. That's unusual. 

gdb doesn't seem to be giving backtraces in .vala files for me with --debug but does seem to be giving them with the -g flag.

Maybe it's a problem with my vala?

Anyway, not a problem for gedit-code-assistance, so this can be marked resolved.
Comment 4 jessevdk@gmail.com 2015-05-02 17:16:33 UTC
I'm fine with changing it from --debug to -g if that works out.
Comment 5 AbdealiJK 2015-05-03 02:36:18 UTC
That would be good
Comment 6 AbdealiJK 2015-05-03 02:37:48 UTC
Created attachment 302785 [details] [review]
Change vala flag for gdb symbols to -g
Comment 7 jessevdk@gmail.com 2015-05-03 07:54:19 UTC
Review of attachment 302785 [details] [review]:

LGTM
Comment 8 jessevdk@gmail.com 2015-05-03 07:55:00 UTC
Review of attachment 302761 [details] [review]:

Obsolete by other patch.
Comment 9 Lasse Schuirmann 2015-05-04 07:18:47 UTC
Attachment 302785 [details] pushed as 20178a7 - Change vala flag for gdb symbols to -g