After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748784 - GtkProgressBar text cannot be superimposed on the progress bar
GtkProgressBar text cannot be superimposed on the progress bar
Status: RESOLVED NOTABUG
Product: gtk+
Classification: Platform
Component: Widget: Other
3.93.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-05-02 00:25 UTC by Phil Wolff
Modified: 2018-04-15 22:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Code to illustrate the bug (2.16 KB, text/x-csrc)
2015-05-02 00:25 UTC, Phil Wolff
Details

Description Phil Wolff 2015-05-02 00:25:03 UTC
Created attachment 302746 [details]
Code to illustrate the bug

Regardless of the arguments to gtk_progress_bar_set_show_text() and gtk_progress_bar_set_text(), the text is always positioned above the progress bar. Contrary to the documentation, the text can no longer be superimposed on the progress bar.
Comment 1 matheus4551 2018-01-01 18:02:26 UTC
How was this fixed?
Comment 2 Phil Wolff 2018-01-01 19:05:15 UTC
It was apparently "fixed" by changing the documentation to match the behavior,, rather than vice versa; the docs now say "Sets whether the progress bar will show text **next to** the bar."
Comment 3 matheus4551 2018-01-12 15:26:56 UTC
That's what I suspected. The new behavior looks cheap and deforms the progress bars, can you reopen the issue?
Comment 4 Phil Wolff 2018-01-12 15:40:16 UTC
Reopening the issue. Changing the documentation miight be considered to be a resolution, but it doesn't fix the problem. Placing the text *above* a horizontal progress bar consumes extra vertical screen space, which is at a premium on smaller screens. It is also inconsistent with the progress bar feature of GtkEntry, which demonstrates that it *is* still possible to have a progress bar with superimposed text.
Comment 5 Daniel Boles 2018-03-31 11:26:04 UTC
The documentation is still wrong here:

> @show_text whether to show superimposed text

I'll patch that, at least.
Comment 6 Timm Bäder 2018-03-31 13:36:48 UTC
> Placing the text *above* a horizontal progress bar consumes extra vertical screen space, which is at a premium on smaller screens. 

Your theme actually uses a full-height progressbar and normal-sized text? Themes can easily adjust the vertical height to be even less then the old progressbar layout.

> It is also inconsistent with the progress bar feature of GtkEntry

That has been virtually unused for years and nobody likes it. It will also very likely vanish for gtk4. The entry progressbar is also just a strip at the bottom in Adwaita.

> *is* still possible to have a progress bar with superimposed text.

GtkEntry does *not* use a GtkProgressbar widget for the progress indicator in gtk3. Which is part of why everyone hates it so much. The possibility to draw things over each other didn't just vanish.


Since all the CSS nodes are fixed for gtk3, we can't change this there, not even add new ones, remove them or change the order. Nobody is going to add extra API for this either, especially not on a stable branch.
Comment 7 Matthias Clasen 2018-04-15 22:38:16 UTC
It is a design change. We're not going to bring back superimposed text. The documentation has been fixed now, I believe.