After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748769 - Allow setting user_agent
Allow setting user_agent
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: GstPlaybin plugin
0.26.x
Other All
: Normal enhancement
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-01 19:10 UTC by Aron Rosenberg
Modified: 2015-05-15 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Expose user agent and allow it to be set. (903 bytes, patch)
2015-05-01 19:10 UTC, Aron Rosenberg 		none Details | Review
Enable setting the user_agent on the underlying gst element (902 bytes, patch)
2015-05-02 17:01 UTC, Aron Rosenberg 		none Details | Review
renderer-gst: Enable setting the user_agent (9.13 KB, patch)
2015-05-10 12:56 UTC, Jens Georg 		committed Details | Review

Description Aron Rosenberg 2015-05-01 19:10:22 UTC 
Created attachment 302734 [details] [review]
Expose user agent and allow it to be set.

Patch to allow setting the user_agent when using gstreamer playbin plugin.
Comment 1 Jens Georg 2015-05-02 08:41:31 UTC 
Is there something missing from that patch?
Comment 2 Aron Rosenberg 2015-05-02 17:01:55 UTC 
Created attachment 302762 [details] [review]
Enable setting the user_agent on the underlying gst element
Comment 3 Aron Rosenberg 2015-05-02 17:03:00 UTC 
I don't think so. I just took over ownership and this was one of the patches we had. It seems to just expose setting the user_agent on the underlying GST element.
Comment 4 Jens Georg 2015-05-03 11:01:25 UTC 
Ah, the second part was missing. In the first version there was no actual setting of the user agent
Comment 5 Jens Georg 2015-05-10 12:56:04 UTC 
Created attachment 303182 [details] [review]
renderer-gst: Enable setting the user_agent

Setting the user_agent on the underlying gst element

Including modifications to use the user-agent in HEAD requests as well to be
consistent.
Comment 6 Jens Georg 2015-05-10 13:19:45 UTC 
Aron, can you check this patch whether that will also work with your use-case?

I see a potential issue if the user-agent is set very late and before av-transport creates the session.
Comment 7 Aron Rosenberg 2015-05-10 16:21:57 UTC 
That should work fine for our use-case. We can init the value early.
Comment 8 Jens Georg 2015-05-15 16:29:17 UTC 
Attachment 303182 [details] pushed as 1b0229d - renderer-gst: Enable setting the user_agent