After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748733 - Disabling the right margin setting isn't honored
Disabling the right margin setting isn't honored
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: preferences
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-01 05:43 UTC by Sean White
Modified: 2015-05-08 03:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support for show-right-margin setting in IdeFileSettings (7.47 KB, patch)
2015-05-03 21:20 UTC, Dimitris Zenios 		committed Details | Review

Description Sean White 2015-05-01 05:43:52 UTC 
The option to disable the right margin is at this moment seemingly tied to the individual settings for each language.  However this has problem, unchecking the box in the language settings in the normal preferences dialog doesn't stop it from being enabled by default when creating or opening a file of that type.  It can still be disabled in the language popover but I believe that only affects the individual file.
Comment 1 Christian Hergert 2015-05-01 06:10:21 UTC 
Is it possible you are also using "editorconfig" too?

Currently, we have this deficiency that if editorconfig settings are used, the gsettings based language settings (which are configured in the preferences window) will not be honored.
Comment 2 Sean White 2015-05-01 07:17:44 UTC 
I'm almost 100% sure I am not.  I haven't got any editorconfig packages on my system and file searches failed to find any .editorconfig files anywhere within my home directory, my current lot of projects being in a subdir.
Comment 3 Dimitris Zenios 2015-05-03 21:20:26 UTC 
Created attachment 302819 [details] [review]
Support for show-right-margin setting in IdeFileSettings
Comment 4 Christian Hergert 2015-05-03 21:35:50 UTC 
Review of attachment 302819 [details] [review]:

LGTM
Comment 5 Christian Hergert 2015-05-03 21:36:32 UTC 
Added a followup commit to set 'show-right-margin' for editorconfig if 'right-margin-position' is set.
Comment 6 Sean White 2015-05-08 03:41:22 UTC 
I built a version from git about a day ago and can confirm that the bug seems to be fixed.  I am now also scouring my home dir for editorconfig.  Thanks for the work