GNOME Bugzilla – Bug 748714
Refine the list view
Last modified: 2018-05-04 12:20:38 UTC
The current list view could be a lot better: * Titles aren't verticlly centered within each row. * The type column isn't needed - this should be communicated with the icon instead. It introduces a lot of visual noise. * The location column shouldn't be needed, in my opinion - since all notes should have the same location. It certainly isn't needed if the location is always the same. * The list is unnecessarily wide. Mockups for something better: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/notes/windowed-notes-list.png
(In reply to Allan Day from comment #0) > The current list view could be a lot better: > > * Titles aren't verticlly centered within each row. This is being addressed by https://bugzilla.gnome.org/show_bug.cgi?id=792665. > * The type column isn't needed - this should be communicated with the icon > instead. It introduces a lot of visual noise. I agree. > * The location column shouldn't be needed, in my opinion - since all notes > should have the same location. It certainly isn't needed if the location is > always the same. Today Bijiben shows and work with more than one location, so I think that should remains. > * The list is unnecessarily wide. It grows/shrinks according to the window size. What do you suggest? Thanks.
Created attachment 367452 [details] [review] main-view: Improve list view This patch removes the type column from list view, reducing visual noise, as that information is also communicated by the icon. It also adds border to notebooks, improving contrast to the shown icons.
(In reply to Allan Day from comment #0) > * The type column isn't needed - this should be communicated with the icon > instead. It introduces a lot of visual noise. Above patch addresses that.
Review of attachment 367452 [details] [review]: I think before removing the column Note/Notebook, we have to consider that Notebook and Note are having the same icons in Adwaita light theme. Say, running: GTK_THEME=Adwaita bijiben the list view shows both note and notebook icon to have sharp corners (a square), while in dark theme, the notebook have a rounded corner, which can be distinguished easily. Also, we have have to put an accessible name (GtkAccessible) for Note and Notebook as such, so that this change won't be an issue for such people. Should we do those changes in a separate commit?
Created attachment 367586 [details] [review] main-view: Improve list view This patch removes the type column from list view, reducing visual noise, as that information is also communicated by the icon. It also adds border to notebooks, improving contrast to the shown icons.
(In reply to Mohammed Sadiq from comment #4) > Review of attachment 367452 [details] [review] [review]: > > I think before removing the column Note/Notebook, we have to consider that > Notebook and Note are having the same icons in Adwaita light theme. > > Say, running: GTK_THEME=Adwaita bijiben > the list view shows both note and notebook icon to have sharp corners (a > square), while in dark theme, the notebook have a rounded corner, which can > be distinguished easily. Thanks Sadiq for noticing that. I've fixed it in the above commit. > > Also, we have have to put an accessible name (GtkAccessible) for Note and > Notebook as such, so that this change won't be an issue for such people. Yeah, I believe we need to fix that, but I believe that's a separate commit.
Created attachment 367587 [details] [review] main-view: Improve list view This patch removes the type column from list view, reducing visual noise, as that information is also communicated by the icon. It also adds border to notebooks, improving contrast to the shown icons.
Review of attachment 367587 [details] [review]: lgtm. Please push to master after the suggested changes. Thanks for your patch. ::: data/resources/Adwaita.css @@ +1,2 @@ .biji-notebook-icon { + border: 1px solid rgba(0,0,0,0.4); nitpick: put spaces after commas ::: src/bjb-main-view.c @@ +476,1 @@ suggestion: As you are already removing the function, may be you can remove these whitelines too. May be we should stick with the style that every function is separated with one (and only one) blank line. Feel free to do what you think is better.
Created attachment 367930 [details] [review] main-view: Improve list view This patch removes the type column from list view, reducing visual noise, as that information is also communicated by the icon. It also adds border to notebooks, improving contrast to the shown icons.
Review of attachment 367930 [details] [review]: Hi Sadiq, I've done the changes you asked for. I agree, we should keep only one empty line between lines, I just overlook that when I did the first patch. Thanks for checking that.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-notes/issues/51.