GNOME Bugzilla – Bug 748711
2 notifications on Qemu crash on launch of new VM
Last modified: 2016-09-20 08:15:55 UTC
Created attachment 302656 [details] boxes screenshot 1. Have an ISO image on a remote SMB server 2. Select it as the source file in the "New" dialogue 3. qemu crashes[1], and I get 2 in-app notifications, one saying that it failed, and another with the "Undo" button which I cannot read.
That was with gnome-boxes-3.16.0-2.fc22.x86_64, updating to the latest now.
Same problem with 3.16.1.
Created attachment 303329 [details] [review] notificationbar: Stack up notifications Instead of displaying all notifications in the same place and ending up with all but one being obstructed, let's stack them up vertically.
Attachment 303329 [details] pushed as dacb098 - notificationbar: Stack up notifications This makes it possible to read the notifications even if there would be 3 at the same time. As for not presenting both, I don't see any easy way to fix that and real issue is Qemu crash anyway.
But I should only see one of those, shouldn't I? The fact that it's removing the VM without having really added it shouldn't appear.
(In reply to Bastien Nocera from comment #5) > But I should only see one of those, shouldn't I? The fact that it's removing > the VM without having really added it shouldn't appear. The VM is added before its launched for you. As I said it won't be easy to fix this completely in Boxes since box should never fail to launch. If/when it does, its a bug somewhere that needs to be solved where it is. Your real bug is in qemu. I kept this bug here for solving the issue of notifications hiding each other.
(In reply to Zeeshan Ali (Khattak) from comment #6) > (In reply to Bastien Nocera from comment #5) > > But I should only see one of those, shouldn't I? The fact that it's removing > > the VM without having really added it shouldn't appear. > > The VM is added before its launched for you. As I said it won't be easy to > fix this completely in Boxes since box should never fail to launch. since -> and.
Seeing as I can't actually see the VM being added and it fails straight away, it looks as if you're adding and then removing the VM. Instead it should say that it failed to add the VM.
(In reply to Bastien Nocera from comment #8) > Seeing as I can't actually see the VM being added and it fails straight > away, it looks as if you're adding and then removing the VM. Instead it > should say that it failed to add the VM. The issue is more created by libvirt sending me 'state_changed' even though it did not since starting of domain failed. I'd guess it's cause they launch qemu process successfully, send out the state_change event and then qemu crashes so when Boxes gets the event, the domain is not running any more. If I provide a patch, could you test it?
Looking at the code, it seems this issue won't be limited to qemu crashes but would happen each time a (non-express-installed) vm fails to start. So I think I should somehow fix this in Boxes.
(In reply to Zeeshan Ali (Khattak) from comment #10) > Looking at the code, it seems this issue won't be limited to qemu crashes > but would happen each time a (non-express-installed) vm fails to start. So I > think I should somehow fix this in Boxes. Scratch that! For actual failed during start, we don't get state-changed signal and hence only get 1 notification. This really is specific to Qemu crashes and I still don't see any easy way to work around this in Boxes.