After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748667 - Adapt to new sound options in MAME >= 0.154
Adapt to new sound options in MAME >= 0.154
Status: RESOLVED FIXED
Product: gnome-video-arcade
Classification: Other
Component: General
0.8.x
Other Linux
: Normal major
: ---
Assigned To: gnome-video-arcade-maint
gnome-video-arcade-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-29 19:15 UTC by Emmanuel Kasper
Modified: 2015-05-08 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix common line arguments of spawned mame process (583 bytes, patch)
2015-04-29 19:15 UTC, Emmanuel Kasper 		none Details | Review

Description Emmanuel Kasper 2015-04-29 19:15:28 UTC 
Created attachment 302607 [details] [review]
Fix common line arguments of spawned mame process

With mame >= 0.154, the command line options for sound in mame are new.
( I am talking about sdlmame, I don't think anyone is using xmame anymore these days)

The attached patch fixes the command line options.
Without it gva is unable to start a specified game properly, as we pass him the rom name as if it were a sound option.
Comment 1 Matthew Barnes 2015-05-06 00:56:57 UTC 
Thanks for the patch.  The change is correct for the current MAME release, but I'd like to preserve compatibility with older versions that used -[no]sound.  That required a bit more work to check the MAME version.

Fixed in two commits.  I credited you on the 2nd.

https://git.gnome.org/browse/gnome-video-arcade/commit/?id=c171f24129eabcc982a877bcb4e1171b8a309a3b

https://git.gnome.org/browse/gnome-video-arcade/commit/?id=c4efcb9f26dd1ca41fd67cc1879a4c04cb0eb1e7
Comment 2 Emmanuel Kasper 2015-05-08 09:51:39 UTC 
Thanks for the quick follow up !